Closed
Bug 748637
Opened 13 years ago
Closed 13 years ago
Refactor primitive value argument conversion to make it more readable/scalable
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
11.46 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Short story: C++ traits templates in a header, much simpler codegen code.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #618138 -
Flags: review?(peterv)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 618138 [details] [diff] [review]
Refactor argument conversion to primitive values to make it easier to extend in the future.
Review of attachment 618138 [details] [diff] [review]:
-----------------------------------------------------------------
Lovely!
::: dom/bindings/PrimitiveConversions.h
@@ +8,5 @@
> + * Conversions from jsval to primitive values
> + */
> +
> +#ifndef mozilla_dom_PrimitiveConversions_h__
> +#define mozilla_dom_PrimitiveConversions_h__
Nit: no trailing underscores, please.
@@ +109,5 @@
> + }
> +};
> +template<>
> +struct PrimitiveConversionTraits<float> : PrimitiveConversionTraits_float {
> +};
I guess this doesn't change behaviour, but is it correct?
|
|
Assignee | |
Comment 3•13 years ago
|
||
> I guess this doesn't change behaviour, but is it correct?
I believe so, yes. Which part looks wrong to you?
Whiteboard: [need review]
|
|
Assignee | |
Comment 4•13 years ago
|
||
> Nit: no trailing underscores, please.
Sure.
|
||
Updated•13 years ago
|
Attachment #618138 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla15
|
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•