748645 - Upload TiledThebesLayerOGL outside the transaction

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

This is causing some regression since we're doing this upload while content is blocked. I wanted to let TiledThebesLayerOGL bake for a day with uploads during the transaction. Note we have another ProcessUploadQueue() in 'TiledThebesLayerOGL::RenderLayer'.

Comment 1

[Chris Lord [:cwiiis]]

Comment on attachment 618150 [details] [diff] [review]
patch

Review of attachment 618150 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Is there a possibility that content could start reusing/destroying tiles before the compositor gets to process them?

::: gfx/layers/opengl/TiledThebesLayerOGL.cpp
@@ +119,5 @@
>  TiledThebesLayerOGL::PaintedTiledLayerBuffer(const BasicTiledLayerBuffer* mTiledBuffer)
>  {
>    mMainMemoryTiledBuffer = *mTiledBuffer;
>    mRegionToUpload.Or(mRegionToUpload, mMainMemoryTiledBuffer.GetLastPaintRegion());
>  

And maybe get rid of this blank line too?

Comment 2

[Benoit Girard (:BenWa)]

It is, however the code should copy out the tiles because the compositor will still have a read lock. If that doesn't work then there's a bug with that part of the tiling work and well have to fix it.

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8aa15433e9e

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 618150 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: Checkerboard reduction
Testing completed (on m-c, etc.): local testing, m-c testing
Risk to taking this patch (and alternatives if risky): Small risk of regressing correctness.
String changes made by this patch: None

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 618150 [details] [diff] [review]
patch

[Triage Comment]
Approving, Fennec beta blocker.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/d8aa15433e9e

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fa3cd2532fe1