74866 - |nsPromiseFlat[C]String| doesn't forward enough functions when attached to a rickg string instance

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Scott Collins]

most of the functions handled in |nsAFlat[C]String| are predicated on the notion
that buffer handles work and the string pointed to uses them.  This is not the
case when pointing at a rickg string.  More forwarding is required.

Comment 1

[Scott Collins]

Attachment: forward all appropriate functions when non-bufferhandle based strings are flat

Comment 2

[Mike Shaver (:shaver emeritus)]

-    protected:
+//  protected:
+    public:

You obviously (?) want to make this protected, but can't: can you add a comment
as to why it a) should be protected, and b) isn't?

Man, am I ever not going to miss obsolete/nsString.

sr=shaver, if you add that comment.

Comment 3

[Scott Collins]

Attachment: addressing shaver's comments

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

r=dbaron.  Using char_type in some places and the real char type in others
seems a bit weird, and also making GetWritableFragment public doesn't seem
necessary at the moment, but since both are in flux right now I don't think
either is a problem...

Comment 5

[Scott Collins]

fix checked in ... btw, we'll be eliminating |char_type| and similar constructs
(only present to make copy/paste editing easier), since people have told me that
seeing the native types makes it easier to read