74870 - Cookie dialog invisible with moz on second screen of Xinerama

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jeffrey Baker]

Debug build pulled 2001-04-05-09 on Linux, built with --enable-xinerama.  If
Mozilla's main window is on the right-hand screen of my setup (the second
screen), the cookie confirmation dialogs are placed off-screen.  The other
dialogs I tried (prefs, open, find) were placed properly.  The cookie dialog is
placed properly if Mozilla's main window is on the left-hand screen.

Comment 1

[sairuh (rarely reading bugmail)]

->mcafee. is this the dialog placement bug? or is it cookie-specific? if the
former, should this be dup'd? if the latter, i'll punt over to the cookie component.

Comment 2

[Chris McAfee]

morse.
Jeffery: it would help a lot if we could eliminate
the Xinerama part of this problem, I have no idea
what that option is.  Does this problem happen on
a vanilla mozilla downloaded nightly build?

Also, this might be a general dialog problem and not cookies,
that would be my 2nd question.

Comment 3

[Jeffrey Baker]

I'll make a fresh build tomorrow and report here.

Comment 4

[Stephen P. Morse]

Sounds like a general dialog problem to me.  Reassigning.

Comment 5

[Peter Trudelle]

I don't see how this is a general problem if it requires a non-standard build
option and still only affects one dialog. ->danm/future

Comment 6

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!

Comment 7

[Chris P. Ross]

As far as I can tell from my limited testing, it is true of all dialogs.
The cookie dialog, and the mail server password dialog.  They all seem
to appear off-screen (I'm running with virtual desktops right now, and
can see where they appear.  They appear to the below of my primary screen,
rather than on my secondary screen, which is to the right of the primary
screen.  Perhaps an X vs. Y login problem in the code?

This I think is a major bug, as if you have this code turned on, the
browser becomes largely unusable, as the dialogs appear off screen and
the browser cannot continue without input it can't expect to get.  Should
the severity be changed to represent this?

BTW, this is not a Linux only bug.  I'm using BSD/OS, and this will
effect any XFree86 server with xinerama.

Comment 8

[Chris P. Ross]

Attachment: fix for xinerama support addition (re: bug #32612)

Comment 9

[Chris P. Ross]

I was right about the nature of the error made that caused dialogs to
appear off-screen.  This simple patch (attachment id=49630) fixes an
error made in the original addition of support for Xinerama (fixing
bug #32612)
I've tested with the post-0.9.4 head, and this patch is all that's
required to make the dialogs appear in the middle of the second
screen, right where they should.

Comment 10

[Chris P. Ross]

adding "patch, review" keywords, assigning to myself.

Comment 11

[Jeffrey Baker]

r=[e-mail], cc += the people who wrote and reviewed this bug

Comment 12

[Christopher Blizzard (:blizzard)]

Comment on attachment 49630 [details] [diff] [review]
fix for xinerama support addition (re: bug #32612)

"oops."

sr=blizzard

Comment 13

[Christopher Blizzard (:blizzard)]

Who needs to check this in?

Comment 14

[Christopher Blizzard (:blizzard)]

Stealing to checkin.

Comment 15

[Christopher Blizzard (:blizzard)]

Checked in.