748716 - don't export ApplicationAccessibleWrap.h

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

1) Remove ApplicationAccessibleWrap.h from EXPORTS section of Makefile.in in msaa/mac/other folders.
2) Add dependency to base/Makefile.in for msaa/mac/other folders similar to how it's done for atk folder

Comment 1

[Mark Capella [:capella]]

Following up / cleanup from 745740 comment#13 ...

When I remove the exports I get base/nsAccessibilityService.cpp(43) : fatal error C1083: Cannot open include file: 'ApplicationAccessibleWrap.h', which exists in atk/mac/msaa/other folders but not in base, so which version does it (and whoever else) need to #include?

I don't follow item 2) above ...

Comment 2

[Mark Capella [:capella]]

Oh ... base/nsAccessNode.cpp(41) : fatal error C1083: Cannot open include file: 'ApplicationAccessibleWrap.h' also occurs (as mentioned in the original bug745740) ...

Comment 3

[alexander :surkov (:asurkov)]

so just add dependency on platform folders to Makefile.in

Comment 4

[Mark Capella [:capella]]

Attachment: Patch (v1)

Well, this works locall on my WIN7 machine. Gonna autoland it to TRY

Comment 5

[Mark Capella [:capella]]

https://tbpl.mozilla.org/?tree=Try&rev=79a77fd9f113

Comment 6

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24f0f921cddd

landed, thanks!

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/24f0f921cddd