Note: There are a few cases of duplicates in user autocompletion which are being worked on.

don't export ApplicationAccessibleWrap.h

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
1) Remove ApplicationAccessibleWrap.h from EXPORTS section of Makefile.in in msaa/mac/other folders.
2) Add dependency to base/Makefile.in for msaa/mac/other folders similar to how it's done for atk folder
(Assignee)

Comment 1

5 years ago
Following up / cleanup from 745740 comment#13 ...

When I remove the exports I get base/nsAccessibilityService.cpp(43) : fatal error C1083: Cannot open include file: 'ApplicationAccessibleWrap.h', which exists in atk/mac/msaa/other folders but not in base, so which version does it (and whoever else) need to #include?

I don't follow item 2) above ...
(Assignee)

Comment 2

5 years ago
Oh ... base/nsAccessNode.cpp(41) : fatal error C1083: Cannot open include file: 'ApplicationAccessibleWrap.h' also occurs (as mentioned in the original bug745740) ...
(Reporter)

Comment 3

5 years ago
so just add dependency on platform folders to Makefile.in
(Assignee)

Comment 4

5 years ago
Created attachment 618979 [details] [diff] [review]
Patch (v1)

Well, this works locall on my WIN7 machine. Gonna autoland it to TRY
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++] → [autoland:-b do -p all -u all -t none][good first bug][mentor=hub@mozilla.com][lang=c++]
(Assignee)

Comment 5

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=79a77fd9f113
Whiteboard: [autoland:-b do -p all -u all -t none][good first bug][mentor=hub@mozilla.com][lang=c++] → [good first bug][mentor=hub@mozilla.com][lang=c++]
(Assignee)

Updated

5 years ago
Attachment #618979 - Flags: review?(surkov.alexander)
(Reporter)

Updated

5 years ago
Attachment #618979 - Flags: review?(surkov.alexander) → review+
(Reporter)

Updated

5 years ago
Blocks: 750216
(Reporter)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/24f0f921cddd

landed, thanks!
Target Milestone: --- → mozilla15
(Assignee)

Updated

5 years ago
Blocks: 748724
https://hg.mozilla.org/mozilla-central/rev/24f0f921cddd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.