Last Comment Bug 748716 - don't export ApplicationAccessibleWrap.h
: don't export ApplicationAccessibleWrap.h
Status: RESOLVED FIXED
[good first bug][mentor=hub@mozilla.c...
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mark Capella [:capella]
:
:
Mentors:
Depends on:
Blocks: cleana11y 748724 750216
  Show dependency treegraph
 
Reported: 2012-04-25 04:36 PDT by alexander :surkov
Modified: 2012-05-02 21:05 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (2.61 KB, patch)
2012-04-27 03:14 PDT, Mark Capella [:capella]
surkov.alexander: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-04-25 04:36:24 PDT
1) Remove ApplicationAccessibleWrap.h from EXPORTS section of Makefile.in in msaa/mac/other folders.
2) Add dependency to base/Makefile.in for msaa/mac/other folders similar to how it's done for atk folder
Comment 1 Mark Capella [:capella] 2012-04-26 19:19:51 PDT
Following up / cleanup from 745740 comment#13 ...

When I remove the exports I get base/nsAccessibilityService.cpp(43) : fatal error C1083: Cannot open include file: 'ApplicationAccessibleWrap.h', which exists in atk/mac/msaa/other folders but not in base, so which version does it (and whoever else) need to #include?

I don't follow item 2) above ...
Comment 2 Mark Capella [:capella] 2012-04-26 19:31:11 PDT
Oh ... base/nsAccessNode.cpp(41) : fatal error C1083: Cannot open include file: 'ApplicationAccessibleWrap.h' also occurs (as mentioned in the original bug745740) ...
Comment 3 alexander :surkov 2012-04-26 23:34:42 PDT
so just add dependency on platform folders to Makefile.in
Comment 4 Mark Capella [:capella] 2012-04-27 03:14:19 PDT
Created attachment 618979 [details] [diff] [review]
Patch (v1)

Well, this works locall on my WIN7 machine. Gonna autoland it to TRY
Comment 5 Mark Capella [:capella] 2012-04-27 03:33:04 PDT
https://tbpl.mozilla.org/?tree=Try&rev=79a77fd9f113
Comment 6 alexander :surkov 2012-04-30 07:44:35 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/24f0f921cddd

landed, thanks!

Note You need to log in before you can comment on or make changes to this bug.