Last Comment Bug 748725 - nsINode::GetParentElement() should return dom::Element*
: nsINode::GetParentElement() should return dom::Element*
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla15
Assigned To: :Aryeh Gregor (away until August 15)
:
Mentors:
Depends on: 756819
Blocks: 685798
  Show dependency treegraph
 
Reported: 2012-04-25 05:02 PDT by :Aryeh Gregor (away until August 15)
Modified: 2012-05-19 12:55 PDT (History)
2 users (show)
ayg: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.53 KB, patch)
2012-04-25 05:07 PDT, :Aryeh Gregor (away until August 15)
bugs: review+
Details | Diff | Review

Description :Aryeh Gregor (away until August 15) 2012-04-25 05:02:34 PDT
Currently it returns nsINode*, so callers can't use nsIContent or dom::Element methods.
Comment 1 :Aryeh Gregor (away until August 15) 2012-04-25 05:07:50 PDT
Created attachment 618212 [details] [diff] [review]
Patch v1

This compiles on my machine, and passes the test for bug 685798.  I doubt it will cause any test failures, but as usual, you can wait for the try run to finish if you like.
Comment 2 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-04-25 05:09:54 PDT
Comment on attachment 618212 [details] [diff] [review]
Patch v1

Thanks.
Comment 3 Mozilla RelEng Bot 2012-04-25 07:59:40 PDT
Autoland Patchset:
	Patches: 618212
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=b08202fd81c5
Try run started, revision b08202fd81c5. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5
Comment 4 :Aryeh Gregor (away until August 15) 2012-04-27 06:21:40 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/64fe2f3a7465
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-04-29 14:10:08 PDT
http://hg.mozilla.org/mozilla-central/rev/64fe2f3a7465
Comment 6 Mozilla RelEng Bot 2012-05-08 10:59:48 PDT
Try run for b08202fd81c5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5
Results (out of 110 total builds):
    exception: 18
    success: 74
    warnings: 18
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-b08202fd81c5
 Timed out after 12 hours without completing.

Note You need to log in before you can comment on or make changes to this bug.