Closed Bug 748725 Opened 8 years ago Closed 8 years ago

nsINode::GetParentElement() should return dom::Element*

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file)

Patch v1
1.53 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
Currently it returns nsINode*, so callers can't use nsIContent or dom::Element methods.
Attached patch Patch v1 — — Splinter Review 
This compiles on my machine, and passes the test for bug 685798.  I doubt it will cause any test failures, but as usual, you can wait for the try run to finish if you like.
Attachment #618212 - Flags: review?(bugs)
Whiteboard: [autoland-try:-u all]
Comment on attachment 618212 [details] [diff] [review]
Patch v1

Thanks.
Attachment #618212 - Flags: review?(bugs) → review+
Whiteboard: [autoland-try:-u all] → [autoland-in-queue]
Autoland Patchset:
	Patches: 618212
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=b08202fd81c5
Try run started, revision b08202fd81c5. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5
https://hg.mozilla.org/integration/mozilla-inbound/rev/64fe2f3a7465
Flags: in-testsuite-
Target Milestone: --- → mozilla15
http://hg.mozilla.org/mozilla-central/rev/64fe2f3a7465
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [autoland-in-queue]
Try run for b08202fd81c5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5
Results (out of 110 total builds):
    exception: 18
    success: 74
    warnings: 18
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-b08202fd81c5
 Timed out after 12 hours without completing.
Depends on: 756819
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.