Last Comment Bug 748725 - nsINode::GetParentElement() should return dom::Element*
: nsINode::GetParentElement() should return dom::Element*
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla15
Assigned To: Aryeh Gregor (:ayg) (next working March 28-April 26)
: Andrew Overholt [:overholt]
Depends on: 756819
Blocks: 685798
  Show dependency treegraph
Reported: 2012-04-25 05:02 PDT by Aryeh Gregor (:ayg) (next working March 28-April 26)
Modified: 2012-05-19 12:55 PDT (History)
2 users (show)
ayg: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (1.53 KB, patch)
2012-04-25 05:07 PDT, Aryeh Gregor (:ayg) (next working March 28-April 26)
bugs: review+
Details | Diff | Splinter Review

Description Aryeh Gregor (:ayg) (next working March 28-April 26) 2012-04-25 05:02:34 PDT
Currently it returns nsINode*, so callers can't use nsIContent or dom::Element methods.
Comment 1 Aryeh Gregor (:ayg) (next working March 28-April 26) 2012-04-25 05:07:50 PDT
Created attachment 618212 [details] [diff] [review]
Patch v1

This compiles on my machine, and passes the test for bug 685798.  I doubt it will cause any test failures, but as usual, you can wait for the try run to finish if you like.
Comment 2 Olli Pettay [:smaug] 2012-04-25 05:09:54 PDT
Comment on attachment 618212 [details] [diff] [review]
Patch v1

Comment 3 Mozilla RelEng Bot 2012-04-25 07:59:40 PDT
Autoland Patchset:
	Patches: 618212
	Branch: mozilla-central => try
Try run started, revision b08202fd81c5. To cancel or monitor the job, see:
Comment 4 Aryeh Gregor (:ayg) (next working March 28-April 26) 2012-04-27 06:21:40 PDT
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-04-29 14:10:08 PDT
Comment 6 Mozilla RelEng Bot 2012-05-08 10:59:48 PDT
Try run for b08202fd81c5 is complete.
Detailed breakdown of the results available here:
Results (out of 110 total builds):
    exception: 18
    success: 74
    warnings: 18
Builds (or logs if builds failed) available at:
 Timed out after 12 hours without completing.

Note You need to log in before you can comment on or make changes to this bug.