nsINode::GetParentElement() should return dom::Element*

RESOLVED FIXED in mozilla15

Status

()

Product:
Core
Component:
DOM
Importance:
--
enhancement
Status:
RESOLVED FIXED
Reported:
7 years ago
Modified:
7 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Version:
Trunk
Target:
mozilla15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Patch v1
1.53 KB, patch
smaug
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
7 years ago 
Currently it returns nsINode*, so callers can't use nsIContent or dom::Element methods.
(Assignee)

Comment 1

•
7 years ago 
Created attachment 618212 [details] [diff] [review]
Patch v1

This compiles on my machine, and passes the test for bug 685798.  I doubt it will cause any test failures, but as usual, you can wait for the try run to finish if you like.
Attachment #618212 - Flags: review?(bugs)
Whiteboard: [autoland-try:-u all]

Comment 2

•
7 years ago 
Comment on attachment 618212 [details] [diff] [review]
Patch v1

Thanks.
Attachment #618212 - Flags: review?(bugs) → review+

Updated

•
7 years ago
Whiteboard: [autoland-try:-u all] → [autoland-in-queue]

Comment 3

•
7 years ago 
Autoland Patchset:
	Patches: 618212
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=b08202fd81c5
Try run started, revision b08202fd81c5. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5
 (Assignee)

Comment 4

•
7 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/64fe2f3a7465
Flags: in-testsuite-
Target Milestone: --- → mozilla15

Comment 5

•
7 years ago 
http://hg.mozilla.org/mozilla-central/rev/64fe2f3a7465
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [autoland-in-queue]

Comment 6

•
7 years ago 
Try run for b08202fd81c5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5
Results (out of 110 total builds):
    exception: 18
    success: 74
    warnings: 18
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-b08202fd81c5
 Timed out after 12 hours without completing.
Depends on: 756819
You need to log in before you can comment on or make changes to this bug.