Closed Bug 748725 Opened 13 years ago Closed 13 years ago

nsINode::GetParentElement() should return dom::Element*

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file)

Currently it returns nsINode*, so callers can't use nsIContent or dom::Element methods.
Attached patch Patch v1Splinter Review
This compiles on my machine, and passes the test for bug 685798. I doubt it will cause any test failures, but as usual, you can wait for the try run to finish if you like.
Attachment #618212 - Flags: review?(bugs)
Whiteboard: [autoland-try:-u all]
Comment on attachment 618212 [details] [diff] [review] Patch v1 Thanks.
Attachment #618212 - Flags: review?(bugs) → review+
Whiteboard: [autoland-try:-u all] → [autoland-in-queue]
Autoland Patchset: Patches: 618212 Branch: mozilla-central => try Destination: http://hg.mozilla.org/try/pushloghtml?changeset=b08202fd81c5 Try run started, revision b08202fd81c5. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5
Flags: in-testsuite-
Target Milestone: --- → mozilla15
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [autoland-in-queue]
Try run for b08202fd81c5 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5 Results (out of 110 total builds): exception: 18 success: 74 warnings: 18 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-b08202fd81c5 Timed out after 12 hours without completing.
Depends on: 756819
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: