748797 - add a build option that forces MOZ_LINKER_EXTRACT to be enabled

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

bug 727960 added/fixed a feature that lets you use MOZ_LINKER_CACHE to specify that the Android linker should load libraries from a specific location on disk. This is handy because you don't have to do the whole package/install dance, you can just push your modified libraries. Benoit noted that it's still a bit of a pain because you have to launch with a very specific commandline, you can't launch from the Android launcher.

We should add a build option to enable this behavior for developer builds, to make launching them easier. Maybe we could even roll in the "load omni.jar from a different location" stuff from bug 745979 while we're at it.

Comment 1

[Benoit Girard (:BenWa)]

That would solve the pain points that have prevented MOZ_LINKER_CACHE from being useful. +1

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: add --enable-android-linker-extract

Comment 3

[(not currently active) Ted Mielczarek]

This is a WIP patch. It *almost* works, in that all the machinery churns, but /data/local/tmp isn't actually writable by Fennec, so it doesn't do the right thing yet. Need to sort out a sane default there, or just use the default cache location (not sure if adb pushing there works, though, given default android permissions).

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: support MOZ_LINKER_EXTRACT=1 as a configure option to turn on linker extraction all the time

This does the trick. Took some fiddling, but works like a charm now.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 620048 [details] [diff] [review]
support MOZ_LINKER_EXTRACT=1 as a configure option to turn on linker extraction all the time

Review of attachment 620048 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but I'd like a review from one of the mobile peers for the java part.

Comment 6

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7e182328da46

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/7e182328da46