add a build option that forces MOZ_LINKER_EXTRACT to be enabled

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
mozilla15
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
bug 727960 added/fixed a feature that lets you use MOZ_LINKER_CACHE to specify that the Android linker should load libraries from a specific location on disk. This is handy because you don't have to do the whole package/install dance, you can just push your modified libraries. Benoit noted that it's still a bit of a pain because you have to launch with a very specific commandline, you can't launch from the Android launcher.

We should add a build option to enable this behavior for developer builds, to make launching them easier. Maybe we could even roll in the "load omni.jar from a different location" stuff from bug 745979 while we're at it.
That would solve the pain points that have prevented MOZ_LINKER_CACHE from being useful. +1
(Assignee)

Comment 2

5 years ago
Created attachment 619158 [details] [diff] [review]
add --enable-android-linker-extract
(Assignee)

Comment 3

5 years ago
This is a WIP patch. It *almost* works, in that all the machinery churns, but /data/local/tmp isn't actually writable by Fennec, so it doesn't do the right thing yet. Need to sort out a sane default there, or just use the default cache location (not sure if adb pushing there works, though, given default android permissions).
(Assignee)

Updated

5 years ago
Summary: add a build option that forces MOZ_LINKER_CACHE to be enabled → add a build option that forces MOZ_LINKER_EXTRACT to be enabled
(Assignee)

Comment 4

5 years ago
Created attachment 620048 [details] [diff] [review]
support MOZ_LINKER_EXTRACT=1 as a configure option to turn on linker extraction all the time

This does the trick. Took some fiddling, but works like a charm now.
Attachment #620048 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Attachment #619158 - Attachment is obsolete: true
Comment on attachment 620048 [details] [diff] [review]
support MOZ_LINKER_EXTRACT=1 as a configure option to turn on linker extraction all the time

Review of attachment 620048 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but I'd like a review from one of the mobile peers for the java part.
Attachment #620048 - Flags: review?(mh+mozilla)
Attachment #620048 - Flags: review?(blassey.bugs)
Attachment #620048 - Flags: review+
Attachment #620048 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/7e182328da46
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/7e182328da46
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.