Disable tearing with OpenGL on OS X

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: vsync)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 618315 [details] [diff] [review]
Set the swap interval to 1

This fixes the problem, I'm not sure if it's the best place to put it.
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try]

Updated

5 years ago
Whiteboard: [autoland-try] → [autoland-in-queue]

Comment 1

5 years ago
Autoland Patchset:
	Patches: 618315
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=57d8c5757121
Try run started, revision 57d8c5757121. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=57d8c5757121
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-in-queue] → [autoland-try -b do -p all -u all -t all]
removing the tag for autoland, since it's been two weeks - but for next time if you want to use try syntax, you need a : between the [autoland-$branch: try syntax] (i know that's not awesome it's just what we have right now.
Whiteboard: [autoland-try -b do -p all -u all -t all]
Any chance we could find someone to add some UI for this in bugzillaJS or a standalone bugzilla extension?
(Assignee)

Updated

5 years ago
Attachment #618315 - Flags: review?(bgirard)
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try: -b do -p all -u all -t all]
Comment on attachment 618315 [details] [diff] [review]
Set the swap interval to 1

r+ with the assumption this doesn't regress Talos and that we don't spend more time in CGLFlushDrawable blocking the main thread.

http://lists.apple.com/archives/mac-opengl/2009/Aug/msg00022.html
Attachment #618315 - Flags: review?(bgirard) → review+
(Assignee)

Comment 5

5 years ago
http://perf.snarkfest.net/compare-talos/index.html?oldRevs=4a3efede4904,80fa9af29d8a&newRev=7b0eef82c5e1&tests=a11y,tdhtml,tdhtml_nochrome,a11y_paint,tdhtml_paint,tdhtml_nochrome_paint,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,tp4m,tp4m_content_rss,tp4m_main_rss,tp4m_main_rss_nochrome,tp4m_nochrome,tp4m_shutdown,tp4m_shutdown_nochrome,tp5r,tp5r_memset,tp5r_pbytes,tp5r_rss,tp5r_shutdown,tp5r_xres,tp5r_paint,tp5r_memset_paint,tp5r_pbytes_paint,tp5r_%cpu_paint,tp5r_modlistbytes_paint,tp5r_rss_paint,tp5r_shutdown_paint,tp5r_xres_paint,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tsspider_paint,tsspider_nochrome_paint,v8,tgfx,tgfx_nochrome,tgfx_paint,tgfx_nochrome_paint,tscroll,tsvg,tsvg_opacity,tzoom,ts,ts_paint,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen,tpaint&submit=true

Comment 6

5 years ago
Would this fix the general tearing that seems to happen when scrolling on OS X 10.6?  (I don't know if we sometimes vs. always use OpenGL.)  If so, that's awesome; I was about to file a bug :)
Do you get any accelerated windows in 'about:support'? Then likely this will.

Comment 8

5 years ago
Yes indeed, so, awesome!  Can't wait for it to land.
Whiteboard: [autoland-try: -b do -p all -u all -t all] → [autoland-try: -b do -p all -u all -t all] vsync
Blocks: 689418
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bd5108af8db

Comment 10

5 years ago
This totally fixes what I was seeing!
Please set the target milestone & assignee when landing on inbound :-)

https://hg.mozilla.org/mozilla-central/rev/4bd5108af8db
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15

Updated

5 years ago
Blocks: 759342
Whiteboard: [autoland-try: -b do -p all -u all -t all] vsync → vsync
Blocks: 676248
Blocks: 635566
Is bug 555834 the same thing as this bug?
You need to log in before you can comment on or make changes to this bug.