Last Comment Bug 748816 - Disable tearing with OpenGL on OS X
: Disable tearing with OpenGL on OS X
Status: RESOLVED FIXED
vsync
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal with 1 vote (vote)
: mozilla15
Assigned To: Jeff Muizelaar [:jrmuizel]
:
Mentors:
Depends on:
Blocks: 759342 635566 676248 689418
  Show dependency treegraph
 
Reported: 2012-04-25 09:08 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2013-02-25 14:07 PST (History)
9 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Set the swap interval to 1 (432 bytes, patch)
2012-04-25 09:08 PDT, Jeff Muizelaar [:jrmuizel]
bgirard: review+
Details | Diff | Review

Description Jeff Muizelaar [:jrmuizel] 2012-04-25 09:08:12 PDT
Created attachment 618315 [details] [diff] [review]
Set the swap interval to 1

This fixes the problem, I'm not sure if it's the best place to put it.
Comment 1 Mozilla RelEng Bot 2012-04-25 19:33:06 PDT
Autoland Patchset:
	Patches: 618315
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=57d8c5757121
Try run started, revision 57d8c5757121. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=57d8c5757121
Comment 2 Lukas Blakk [:lsblakk] use ?needinfo 2012-05-11 14:58:09 PDT
removing the tag for autoland, since it's been two weeks - but for next time if you want to use try syntax, you need a : between the [autoland-$branch: try syntax] (i know that's not awesome it's just what we have right now.
Comment 3 Benoit Girard (:BenWa) 2012-05-12 07:35:10 PDT
Any chance we could find someone to add some UI for this in bugzillaJS or a standalone bugzilla extension?
Comment 4 Benoit Girard (:BenWa) 2012-05-15 20:58:20 PDT
Comment on attachment 618315 [details] [diff] [review]
Set the swap interval to 1

r+ with the assumption this doesn't regress Talos and that we don't spend more time in CGLFlushDrawable blocking the main thread.

http://lists.apple.com/archives/mac-opengl/2009/Aug/msg00022.html
Comment 6 Luke Wagner [:luke] 2012-05-17 08:25:16 PDT
Would this fix the general tearing that seems to happen when scrolling on OS X 10.6?  (I don't know if we sometimes vs. always use OpenGL.)  If so, that's awesome; I was about to file a bug :)
Comment 7 Benoit Girard (:BenWa) 2012-05-17 08:31:36 PDT
Do you get any accelerated windows in 'about:support'? Then likely this will.
Comment 8 Luke Wagner [:luke] 2012-05-17 12:34:16 PDT
Yes indeed, so, awesome!  Can't wait for it to land.
Comment 9 Jeff Muizelaar [:jrmuizel] 2012-05-23 21:42:47 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bd5108af8db
Comment 10 Luke Wagner [:luke] 2012-05-24 05:25:32 PDT
This totally fixes what I was seeing!
Comment 11 Ed Morley [:emorley] 2012-05-24 09:20:24 PDT
Please set the target milestone & assignee when landing on inbound :-)

https://hg.mozilla.org/mozilla-central/rev/4bd5108af8db
Comment 12 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2013-02-25 14:07:29 PST
Is bug 555834 the same thing as this bug?

Note You need to log in before you can comment on or make changes to this bug.