748816 - Disable tearing with OpenGL on OS X

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Set the swap interval to 1

This fixes the problem, I'm not sure if it's the best place to put it.

Comment 1

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 618315
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=57d8c5757121
Try run started, revision 57d8c5757121. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=57d8c5757121

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

removing the tag for autoland, since it's been two weeks - but for next time if you want to use try syntax, you need a : between the [autoland-$branch: try syntax] (i know that's not awesome it's just what we have right now.

Comment 3

[Benoit Girard (:BenWa)]

Any chance we could find someone to add some UI for this in bugzillaJS or a standalone bugzilla extension?

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 618315 [details] [diff] [review]
Set the swap interval to 1

r+ with the assumption this doesn't regress Talos and that we don't spend more time in CGLFlushDrawable blocking the main thread.

http://lists.apple.com/archives/mac-opengl/2009/Aug/msg00022.html

Comment 5

[Jeff Muizelaar [:jrmuizel]]

http://perf.snarkfest.net/compare-talos/index.html?oldRevs=4a3efede4904,80fa9af29d8a&newRev=7b0eef82c5e1&tests=a11y,tdhtml,tdhtml_nochrome,a11y_paint,tdhtml_paint,tdhtml_nochrome_paint,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,tp4m,tp4m_content_rss,tp4m_main_rss,tp4m_main_rss_nochrome,tp4m_nochrome,tp4m_shutdown,tp4m_shutdown_nochrome,tp5r,tp5r_memset,tp5r_pbytes,tp5r_rss,tp5r_shutdown,tp5r_xres,tp5r_paint,tp5r_memset_paint,tp5r_pbytes_paint,tp5r_%cpu_paint,tp5r_modlistbytes_paint,tp5r_rss_paint,tp5r_shutdown_paint,tp5r_xres_paint,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tsspider_paint,tsspider_nochrome_paint,v8,tgfx,tgfx_nochrome,tgfx_paint,tgfx_nochrome_paint,tscroll,tsvg,tsvg_opacity,tzoom,ts,ts_paint,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen,tpaint&submit=true

Comment 6

[Luke Wagner [:luke]]

Would this fix the general tearing that seems to happen when scrolling on OS X 10.6?  (I don't know if we sometimes vs. always use OpenGL.)  If so, that's awesome; I was about to file a bug :)

Comment 7

[Benoit Girard (:BenWa)]

Do you get any accelerated windows in 'about:support'? Then likely this will.

Comment 8

[Luke Wagner [:luke]]

Yes indeed, so, awesome!  Can't wait for it to land.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4bd5108af8db

Comment 10

[Luke Wagner [:luke]]

This totally fixes what I was seeing!

Comment 11

[Ed Morley [:emorley]]

Please set the target milestone & assignee when landing on inbound :-)

https://hg.mozilla.org/mozilla-central/rev/4bd5108af8db

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Is bug 555834 the same thing as this bug?