The default bug view has changed. See this FAQ.

Remove useless painting suppression code

RESOLVED FIXED in Firefox 14

Status

()

Core
Widget: Android
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla15
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox14+ fixed, firefox15 fixed, blocking-fennec1.0 +)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 618328 [details] [diff] [review]
Don't ask if we're suppressed when we're never suppressed

Bug 732564 disabled the painting suppression code in browser.js. This patch keeps us from calling it.
(Assignee)

Updated

5 years ago
Attachment #618328 - Flags: review?(bugmail.mozilla)
(Assignee)

Updated

5 years ago
Attachment #618328 - Attachment is patch: true
Comment on attachment 618328 [details] [diff] [review]
Don't ask if we're suppressed when we're never suppressed

Review of attachment 618328 [details] [diff] [review]:
-----------------------------------------------------------------

It would be good to also remove the paintingSuppressed thing from browser.js and the IDL.
(Assignee)

Comment 2

5 years ago
Created attachment 618335 [details] [diff] [review]
Remove dead paint supression code

Removing it all together wasn't much more than doing it in two patches so I've included that.
Attachment #618328 - Attachment is obsolete: true
Attachment #618328 - Flags: review?(bugmail.mozilla)
Attachment #618335 - Flags: review?(bugmail.mozilla)
Comment on attachment 618335 [details] [diff] [review]
Remove dead paint supression code

Review of attachment 618335 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I don't know what the rules are for changing the UUID on the IDL, but that should be done as well if it's needed.
Attachment #618335 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/f60b22354545
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
(Assignee)

Comment 5

5 years ago
Comment on attachment 618335 [details] [diff] [review]
Remove dead paint supression code

[Approval Request Comment]
User impact if declined: decreased painting performance
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, the code is dead
String changes made by this patch: none
Attachment #618335 - Flags: approval-mozilla-aurora?

Comment 6

5 years ago
Let's find out if this is a beta blocker before landing on Aurora 14.
blocking-fennec1.0: --- → ?
Comment on attachment 618335 [details] [diff] [review]
Remove dead paint supression code

probably not a blocker, but really safe and a nice easy win
Attachment #618335 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/14a10a95e377
tracking-firefox14: --- → +
status-firefox14: --- → fixed
status-firefox15: --- → fixed
blocking-fennec1.0: ? → +

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.