Closed Bug 748832 Opened 12 years ago Closed 12 years ago

Remove useless painting suppression code

Categories

(Core Graveyard :: Widget: Android, defect)

Product:
Core Graveyard
Component:
Widget: Android
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox14+ fixed, firefox15 fixed, blocking-fennec1.0 +)

Status:
RESOLVED FIXED
Milestone:
mozilla15
Tracking Flags:
Tracking Status
firefox14 + fixed
firefox15 --- fixed
blocking-fennec1.0 --- +

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Remove dead paint supression code
2.40 KB, patch
kats
: review+
blassey
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Bug 732564 disabled the painting suppression code in browser.js. This patch keeps us from calling it.
Attachment #618328 - Flags: review?(bugmail.mozilla)
Attachment #618328 - Attachment is patch: true
Comment on attachment 618328 [details] [diff] [review] Don't ask if we're suppressed when we're never suppressed Review of attachment 618328 [details] [diff] [review]: ----------------------------------------------------------------- It would be good to also remove the paintingSuppressed thing from browser.js and the IDL.
Removing it all together wasn't much more than doing it in two patches so I've included that.
Attachment #618328 - Attachment is obsolete: true
Attachment #618328 - Flags: review?(bugmail.mozilla)
Attachment #618335 - Flags: review?(bugmail.mozilla)
Comment on attachment 618335 [details] [diff] [review] Remove dead paint supression code Review of attachment 618335 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. I don't know what the rules are for changing the UUID on the IDL, but that should be done as well if it's needed.
Attachment #618335 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/f60b22354545
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment on attachment 618335 [details] [diff] [review] Remove dead paint supression code [Approval Request Comment] User impact if declined: decreased painting performance Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low, the code is dead String changes made by this patch: none
Attachment #618335 - Flags: approval-mozilla-aurora?
Let's find out if this is a beta blocker before landing on Aurora 14.
blocking-fennec1.0: --- → ?
Comment on attachment 618335 [details] [diff] [review] Remove dead paint supression code probably not a blocker, but really safe and a nice easy win
Attachment #618335 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
blocking-fennec1.0: ? → +
Whiteboard: [qa-]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: