748855 - Allow the starring of pending/running builds & tests, for pre-emptive marking of mass bustage

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: TBPL, enhancement)

Description

[Ed Morley [:emorley]]

Whenever there is some kind of mass bustage that's been backed out half a dozen pushes later, I always end up playing the whack-a-mole game for the next few hours, starring those failures with the backout changeset rev. This happens particularly for test failures, which are obviously much more spread out over time compared to say compile failures.

For instances where the subsequent pushes look pretty safe, it would be great if I could pre-emptively star the pending but expected to fail builds/tests in one go, rather than having to wait for them to finish in dribs and drabs.

Comment 1

[Ed Morley [:emorley]]

ewong asked about this on IRC, so here are my initial thoughts:

1) The link needs to be shown all the time, at: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/3631325e489e/js/UserInterface.js#l1495

2) In js/AddCommentUI.js:

  * Posts to bugzilla (_postOneBug) if there was a bug suggestion (we won't have one, since we'll be starring things like "backed out in: <changeset_hash>", so we can ignore this.

  * In _postOneComment() submits the comment to the TBPL DB as well as OrangeFactor (WOO). They both expect a machine name & start time, so we'd either need to just add this feature for running builds only, or else make sure both client and server side can deal with empty/fake values. In addition, WOO requires a log URL, which we obviously won't have on either running or pending, so we'll also need to deal with that.

  * _updateBuildList() ignores jobs that haven't finished, so will need to tweak that.

3) Pending/running jobs will need to be made draggable (into the 'add a comment' dialog), at:
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/3631325e489e/js/UserInterface.js#l119

There's no doubt several other bits I've forgotten, but the above should give a rough idea :-)

Comment 2

[Ed Morley [:emorley]]

Philor, are there any major pitfalls I've overlooked? :-)

Comment 3

[Edmund Wong (:ewong)]

Just updating the links since tbpl now resides in hg.mozilla.org/webtools/tbpl.
(Not exactly sure if the lines are right. Please correct me if I'm wrong.)

> 
> 1) The link needs to be shown all the time, at:
> http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/
> 3631325e489e/js/UserInterface.js#l1495

http://hg.mozilla.org/webtools/tbpl/file/6b6b9a561260/js/UserInterface.js#l1490

> 
> 2) In js/AddCommentUI.js:
> 
>   * Posts to bugzilla (_postOneBug) if there was a bug suggestion (we won't
> have one, since we'll be starring things like "backed out in:
> <changeset_hash>", so we can ignore this.
> 
>   * In _postOneComment() submits the comment to the TBPL DB as well as
> OrangeFactor (WOO). They both expect a machine name & start time, so we'd
> either need to just add this feature for running builds only, or else make
> sure both client and server side can deal with empty/fake values. In
> addition, WOO requires a log URL, which we obviously won't have on either
> running or pending, so we'll also need to deal with that.
> 
>   * _updateBuildList() ignores jobs that haven't finished, so will need to
> tweak that.
> 
> 3) Pending/running jobs will need to be made draggable (into the 'add a
> comment' dialog), at:
> http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/
> 3631325e489e/js/UserInterface.js#l119

http://hg.mozilla.org/webtools/tbpl/file/6b6b9a561260/js/UserInterface.js#l118

Comment 4

[Ed Morley [:emorley]]

In discussing TBPLv2, ensuring we supported this feature came up. As part of thinking through that, I now believe this is too involved to be worth tacking onto the current TBPL - and instead we just need to design for it from the ground up (basically it's impossible to get buildbot IDs when the jobs are pending, since buildbot only has build_request_ids at that point). Sorry! :-)

Comment 5

[Ed Morley [:emorley]]

This is fixed in Treeherder.
Wontfix here since TBPL is nearing EOL.