Last Comment Bug 748890 - Make getting the load context in nsExternalHelperAppService work in multiprocess mode
: Make getting the load context in nsExternalHelperAppService work in multiproc...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla16
Assigned To: :Ehsan Akhgari (busy, don't ask for review please)
:
Mentors:
Depends on: 722845 722868
Blocks: PBnGen
  Show dependency treegraph
 
Reported: 2012-04-25 12:03 PDT by :Ehsan Akhgari (busy, don't ask for review please)
Modified: 2012-06-30 12:45 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.91 KB, patch)
2012-06-28 12:32 PDT, :Ehsan Akhgari (busy, don't ask for review please)
josh: review+
Details | Diff | Review

Description :Ehsan Akhgari (busy, don't ask for review please) 2012-04-25 12:03:10 PDT
See bug 722868 comment 17.
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2012-06-26 19:02:22 PDT
Josh, now that bug 722845 has landed, what needs to be done here?
Comment 2 Josh Matthews [:jdm] 2012-06-26 20:31:30 PDT
Instead of QIing for nsIChannel, QI for nsIPrivateBrowsingConsumer which supports IPC channels.
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2012-06-27 10:31:11 PDT
OK, I'll take this when bug 722868 lands.  I don't know which one of the 24 git branches that I maintain for bug 722868 was the latest one!
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2012-06-28 12:32:35 PDT
Created attachment 637633 [details] [diff] [review]
Patch (v1)
Comment 5 Josh Matthews [:jdm] 2012-06-28 21:30:39 PDT
Comment on attachment 637633 [details] [diff] [review]
Patch (v1)

I prefer folding it all into a |bool inPrivateBrowsing = pbConsumer && pbConsumer->UsePrivateBrowsing()|, but otherwise good.
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2012-06-29 08:29:10 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/af15b0a28ed8
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-06-30 12:45:27 PDT
https://hg.mozilla.org/mozilla-central/rev/af15b0a28ed8

Note You need to log in before you can comment on or make changes to this bug.