Make getting the load context in nsExternalHelperAppService work in multiprocess mode

RESOLVED FIXED in mozilla16

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla16
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See bug 722868 comment 17.
Josh, now that bug 722845 has landed, what needs to be done here?

Comment 2

5 years ago
Instead of QIing for nsIChannel, QI for nsIPrivateBrowsingConsumer which supports IPC channels.
OK, I'll take this when bug 722868 lands.  I don't know which one of the 24 git branches that I maintain for bug 722868 was the latest one!
Assignee: nobody → ehsan
Depends on: 722868
Created attachment 637633 [details] [diff] [review]
Patch (v1)
Attachment #637633 - Flags: review?(josh)

Comment 5

5 years ago
Comment on attachment 637633 [details] [diff] [review]
Patch (v1)

I prefer folding it all into a |bool inPrivateBrowsing = pbConsumer && pbConsumer->UsePrivateBrowsing()|, but otherwise good.
Attachment #637633 - Flags: review?(josh) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/af15b0a28ed8
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/af15b0a28ed8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.