748890 - Make getting the load context in nsExternalHelperAppService work in multiprocess mode

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[(no longer active)]

See bug 722868 comment 17.

Comment 1

[(no longer active)]

Josh, now that bug 722845 has landed, what needs to be done here?

Comment 2

[Josh Matthews [:jdm]]

Instead of QIing for nsIChannel, QI for nsIPrivateBrowsingConsumer which supports IPC channels.

Comment 3

[(no longer active)]

OK, I'll take this when bug 722868 lands.  I don't know which one of the 24 git branches that I maintain for bug 722868 was the latest one!

Comment 4

[(no longer active)]

Attachment: Patch (v1)

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 637633 [details] [diff] [review]
Patch (v1)

I prefer folding it all into a |bool inPrivateBrowsing = pbConsumer && pbConsumer->UsePrivateBrowsing()|, but otherwise good.

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af15b0a28ed8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af15b0a28ed8