Closed Bug 748890 Opened 9 years ago Closed 9 years ago

Make getting the load context in nsExternalHelperAppService work in multiprocess mode

Categories

(Core :: DOM: Navigation, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

See bug 722868 comment 17.
Josh, now that bug 722845 has landed, what needs to be done here?
Instead of QIing for nsIChannel, QI for nsIPrivateBrowsingConsumer which supports IPC channels.
OK, I'll take this when bug 722868 lands.  I don't know which one of the 24 git branches that I maintain for bug 722868 was the latest one!
Assignee: nobody → ehsan
Depends on: 722868
Attached patch Patch (v1)Splinter Review
Attachment #637633 - Flags: review?(josh)
Comment on attachment 637633 [details] [diff] [review]
Patch (v1)

I prefer folding it all into a |bool inPrivateBrowsing = pbConsumer && pbConsumer->UsePrivateBrowsing()|, but otherwise good.
Attachment #637633 - Flags: review?(josh) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/af15b0a28ed8
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/af15b0a28ed8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.