748914 - implement Telemetry.clearHistogram

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Nathan Froyd [:froydnj]]

This function would be useful for testing purposes (e.g. about:memory) and for short-lived telemetry about telemetry.

Comment 1

[(dormant account)]

Actually I think this should be done on the histogram js object.
Code look like nsITelemetry.getHistogramById("foo").clear()
 ie "clear" would live next to the snapshot() function in http://mxr.mozilla.org/mozilla-central/source//toolkit/components/telemetry/Telemetry.cpp#478

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Taras Glek (:taras) from comment #1)
> Actually I think this should be done on the histogram js object.

I guess it doesn't matter whether the histogram gets removed (Telemetry.clearHistogram) or whether we do the above once bug 748907 is implemented.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: part 1 - implement Histogram::Clear

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: add JS histogram.clear method

Opted for the JS-centric way of doing it, seemed marginally better.

Comment 5

[(dormant account)]

Comment on attachment 622092 [details] [diff] [review]
part 1 - implement Histogram::Clear

General idea seems good.
seems like range_checksum_ should be touched. Also should consider using a c++ copy constructor to wipe the sampleset instead of implementing it explicitly(and possibly missing stuff)

Comment 6

[Nathan Froyd [:froydnj]]

Attachment: part 1 - implement Histogram::Clear

We already use the default operator= for SnapshotSample; just reuse it after resizing the cleared source appropriately.

Comment 7

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bcfe9bfa077
https://hg.mozilla.org/integration/mozilla-inbound/rev/d46217a53bf8

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3bcfe9bfa077
https://hg.mozilla.org/mozilla-central/rev/d46217a53bf8