748915 - Implement JS_IsArrayBufferViewObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Also includes some warnings fixes.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Implement JS_IsArrayBufferViewObject

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 618398 [details] [diff] [review]
Implement JS_IsArrayBufferViewObject

Review of attachment 618398 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jstypedarray.h
@@ +57,5 @@
>   * explicitly and passed to an ArrayBufferView subclass, or can be created
>   * implicitly by constructing a TypedArray with a size.
>   */
> +class ArrayBufferObject : public JSObject {
> +public:

{ on new line, public: indented by two.

::: js/src/vm/ObjectImpl.h
@@ +574,5 @@
>  class ObjectElements
>  {
>      friend struct ::JSObject;
>      friend class ObjectImpl;
> +    friend class js::ArrayBufferObject;

You don't need the js:: prefix here.

Comment 3

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a708ccedb3d

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3a708ccedb3d