Last Comment Bug 748915 - Implement JS_IsArrayBufferViewObject
: Implement JS_IsArrayBufferViewObject
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Steve Fink [:sfink] [:s:]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-25 12:48 PDT by Steve Fink [:sfink] [:s:]
Modified: 2012-04-26 10:43 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Implement JS_IsArrayBufferViewObject (3.62 KB, patch)
2012-04-25 12:48 PDT, Steve Fink [:sfink] [:s:]
jwalden+bmo: review+
Details | Diff | Splinter Review

Description Steve Fink [:sfink] [:s:] 2012-04-25 12:48:23 PDT
Also includes some warnings fixes.
Comment 1 Steve Fink [:sfink] [:s:] 2012-04-25 12:48:31 PDT
Created attachment 618398 [details] [diff] [review]
Implement JS_IsArrayBufferViewObject
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2012-04-25 13:55:51 PDT
Comment on attachment 618398 [details] [diff] [review]
Implement JS_IsArrayBufferViewObject

Review of attachment 618398 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jstypedarray.h
@@ +57,5 @@
>   * explicitly and passed to an ArrayBufferView subclass, or can be created
>   * implicitly by constructing a TypedArray with a size.
>   */
> +class ArrayBufferObject : public JSObject {
> +public:

{ on new line, public: indented by two.

::: js/src/vm/ObjectImpl.h
@@ +574,5 @@
>  class ObjectElements
>  {
>      friend struct ::JSObject;
>      friend class ObjectImpl;
> +    friend class js::ArrayBufferObject;

You don't need the js:: prefix here.
Comment 3 Steve Fink [:sfink] [:s:] 2012-04-25 16:59:48 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a708ccedb3d
Comment 4 Ed Morley [:emorley] 2012-04-26 10:43:56 PDT
https://hg.mozilla.org/mozilla-central/rev/3a708ccedb3d

Note You need to log in before you can comment on or make changes to this bug.