Implement JS_IsArrayBufferViewObject

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Also includes some warnings fixes.
(Assignee)

Comment 1

5 years ago
Created attachment 618398 [details] [diff] [review]
Implement JS_IsArrayBufferViewObject
Attachment #618398 - Flags: review?(jwalden+bmo)
Comment on attachment 618398 [details] [diff] [review]
Implement JS_IsArrayBufferViewObject

Review of attachment 618398 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jstypedarray.h
@@ +57,5 @@
>   * explicitly and passed to an ArrayBufferView subclass, or can be created
>   * implicitly by constructing a TypedArray with a size.
>   */
> +class ArrayBufferObject : public JSObject {
> +public:

{ on new line, public: indented by two.

::: js/src/vm/ObjectImpl.h
@@ +574,5 @@
>  class ObjectElements
>  {
>      friend struct ::JSObject;
>      friend class ObjectImpl;
> +    friend class js::ArrayBufferObject;

You don't need the js:: prefix here.
Attachment #618398 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a708ccedb3d
Target Milestone: --- → mozilla15

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3a708ccedb3d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.