Closed Bug 748915 Opened 9 years ago Closed 9 years ago

Implement JS_IsArrayBufferViewObject

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

Also includes some warnings fixes.
Attachment #618398 - Flags: review?(jwalden+bmo)
Comment on attachment 618398 [details] [diff] [review]
Implement JS_IsArrayBufferViewObject

Review of attachment 618398 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jstypedarray.h
@@ +57,5 @@
>   * explicitly and passed to an ArrayBufferView subclass, or can be created
>   * implicitly by constructing a TypedArray with a size.
>   */
> +class ArrayBufferObject : public JSObject {
> +public:

{ on new line, public: indented by two.

::: js/src/vm/ObjectImpl.h
@@ +574,5 @@
>  class ObjectElements
>  {
>      friend struct ::JSObject;
>      friend class ObjectImpl;
> +    friend class js::ArrayBufferObject;

You don't need the js:: prefix here.
Attachment #618398 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/3a708ccedb3d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.