748991 - The Find in Page Dialog does not vertically center the highlighted result like the findbar does.

Status: RESOLVED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[David E. Ross]

Bug #171237 was not implemented for the situation when the preference variable browser.findbar.enabled is set to "False" to use a popup instead of the Find tool bar.  This setting is required as a workaround for the fact that the Find tool bar lacks the ability to disable wrapped searches.  

I have verified this while running SeaMonkey 2.9 in Safe Mode.

Comment 1

[(no longer active)]

Whatever code is responsible for that dialog needs to use the SCROLL_CENTER_VERTICALLY when doing scrolling.

Comment 2

[Philip Chee]

Ehsan is this the correct place to add SCROLL_CENTER_VERTICALLY ?
http://hg.mozilla.org/mozilla-central/annotate/21da3f655b30/embedding/components/find/src/nsWebBrowserFind.cpp#l450

Comment 3

[Philip Chee]

Attachment: Patch v1.0 use SCROLL_CENTER_VERTICALLY when doing scrolling.

> Whatever code is responsible for that dialog needs to use the
> SCROLL_CENTER_VERTICALLY when doing scrolling.

This patch adds SCROLL_CENTER_VERTICALLY to nsWebBrowserFind::SetSelectionAndScroll()

Comment 4

[(no longer active)]

Comment on attachment 618688 [details] [diff] [review]
Patch v1.0 use SCROLL_CENTER_VERTICALLY when doing scrolling.

Review of attachment 618688 [details] [diff] [review]:
-----------------------------------------------------------------

Note that I have not tested this patch at all, and I don't know if there's more that needs to be done here, but this will be at least part of the solution, if not the whole fix.

Comment 5

[Philip Chee]

Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3c3212181369

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3c3212181369