Closed Bug 748991 Opened 8 years ago Closed 8 years ago

The Find in Page Dialog does not vertically center the highlighted result like the findbar does.

Categories

(SeaMonkey :: Find In Page, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.12

People

(Reporter: david, Assigned: philip.chee)

References

Details

Attachments

(1 file)

Bug #171237 was not implemented for the situation when the preference variable browser.findbar.enabled is set to "False" to use a popup instead of the Find tool bar.  This setting is required as a workaround for the fact that the Find tool bar lacks the ability to disable wrapped searches.  

I have verified this while running SeaMonkey 2.9 in Safe Mode.
Whatever code is responsible for that dialog needs to use the SCROLL_CENTER_VERTICALLY when doing scrolling.
Component: Layout → Find In Page
Product: Core → SeaMonkey
QA Contact: layout → keyboard.fayt
Ehsan is this the correct place to add SCROLL_CENTER_VERTICALLY ?
http://hg.mozilla.org/mozilla-central/annotate/21da3f655b30/embedding/components/find/src/nsWebBrowserFind.cpp#l450
Depends on: 171237
Summary: Incomplete Implementation of Bug #171237 → The Find in Page Dialog does not vertically center the highlighted result like the findbar does.
> Whatever code is responsible for that dialog needs to use the
> SCROLL_CENTER_VERTICALLY when doing scrolling.

This patch adds SCROLL_CENTER_VERTICALLY to nsWebBrowserFind::SetSelectionAndScroll()
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #618688 - Flags: review?(ehsan)
Comment on attachment 618688 [details] [diff] [review]
Patch v1.0 use SCROLL_CENTER_VERTICALLY when doing scrolling.

Review of attachment 618688 [details] [diff] [review]:
-----------------------------------------------------------------

Note that I have not tested this patch at all, and I don't know if there's more that needs to be done here, but this will be at least part of the solution, if not the whole fix.
Attachment #618688 - Flags: review?(ehsan) → review+
Target Milestone: --- → seamonkey2.12
https://hg.mozilla.org/mozilla-central/rev/3c3212181369
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.