749106 - Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect, P3)

Comment 1

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/comm-central/source/suite/common/src/nsSessionStore.js
1097   undoCloseTab: function sss_undoCloseTab(aWindow, aIndex) {
[...]

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey

(Untested.)

Comment 3

[[e-mail]]

Comment on attachment 621043 [details] [diff] [review]
(Av1) Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey

Please cut out the irrelevant changes.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 621043 [details] [diff] [review]
(Av1) Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey

(In reply to [e-mail] from comment #3)
> Please cut out the irrelevant changes.

Fix:
The main change is the focus call.

Nits:
The other change they did is s/browser/tabbrowser/, which is consistent with the rest of the (SM) file.
The additional change I did is s/var/let/ on the modified lines, to be closer to FF code and as SM file already has a mix of them.

Would you accept them in 2 patches?

Comment 5

[[e-mail]]

Comment on attachment 621043 [details] [diff] [review]
(Av1) Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey

OK, fair enough on the browser/tabbrowser changes, but I don't want let.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey [Checked in: Comment 7]

Av1, with comment 5 suggestion(s).

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 621075 [details] [diff] [review]
(Av2) Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey
[Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/dacd84a980a5


[Approval Request Comment]
No risk. Not mandatory, but let's match Firefox.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 621075 [details] [diff] [review]
(Av2) Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey
[Checked in: Comment 7]

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 621075 [details] [diff] [review]
(Av2) Port |Bug 746837 - Fix sessionstore to handle an exception thrown when attempting to focus a window that has been navigated| to SeaMonkey
[Checked in: Comment 7]

a- due to "No risk. Not mandatory, but let's match Firefox."