Closed Bug 749118 Opened 9 years ago Closed 9 years ago

CSS opacity regression

Categories

(Core :: Graphics, defect)

10 Branch
x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
firefox12 --- affected
firefox13 --- verified
firefox14 - verified

People

(Reporter: noelamac, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [qa+])

Attachments

(5 files)

There seems to be a regression with CSS opacity in Firefox 12 (or at least it was not present in earlier versions). I am attaching 3 files:

- sample_regression.html (with an opacity level set that exposes the problem)
- sample.html (opacity level set to "1" and working as it should)
- sample.jpg (background image)
- dots.gif (animated gif)

What happens is that when setting the transparency to a layer, the second frame of the animated GIF inside the layer is lost.
Attachment #618598 - Attachment mime type: text/plain → text/html
Attachment #618599 - Attachment mime type: text/plain → text/html
Regression window(m-c)
Cannot reproduce:
http://hg.mozilla.org/mozilla-central/rev/e1ae143cc842
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111026 Firefox/10.0a1 ID:20111026120007
Can reproduce:
http://hg.mozilla.org/mozilla-central/rev/16a8d2ab5240
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111026 Firefox/10.0a1 ID:20111026163203
pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e1ae143cc842&tochange=16a8d2ab5240

Regression window(m-i)
Cannot reproduce:
http://hg.mozilla.org/integration/mozilla-inbound/rev/98013fe19dcb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 ID:20111025195747
Can reproduce:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d7f3bfc7cd46
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 ID:20111025203245
pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=98013fe19dcb&tochange=d7f3bfc7cd46

Last good; 68d6ef3d84a3
First bad; 8b89d7037306
Triggered by;
8b89d7037306	Matt Woodrow — Bug 695275 - Fix conversion of ThebesLayers to ImageLayers. r=roc
Blocks: 695275
Status: UNCONFIRMED → NEW
Component: General → Graphics
Ever confirmed: true
Keywords: regression
OS: Linux → All
Product: Firefox → Core
QA Contact: general → thebes
Version: 12 Branch → 10 Branch
Attachment #618856 - Flags: review? → review?(joe)
Blocks: 749457
This is not a recent regression. Please nominate for Aurora/Beta approval if you'd like to get this in earlier than FF15.
Comment on attachment 618856 [details] [diff] [review]
Translate the source correctly

Review of attachment 618856 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/src/RasterImage.cpp
@@ +852,5 @@
>                                                               gfxASurface::ImageFormatARGB32);
>    gfxContext ctx(imgsurface);
>    ctx.SetOperator(gfxContext::OPERATOR_SOURCE);
> +  ctx.Rectangle(framerect);
> +  ctx.Translate(framerect.TopLeft());

A better fix to this would be ctx.SetPattern(pattern, framerect.TopLeft());
Attachment #618856 - Flags: review?(joe) → review-
That API doesn't exist :)

We could adjust the pattern matrix instead? But that doesn't sound easier than my fix, and we'd need to account for a possible existing pattern matrix.
Comment on attachment 618856 [details] [diff] [review]
Translate the source correctly

Review of attachment 618856 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, I was thinking of SetSource. Sorry!
Attachment #618856 - Flags: review- → review+
https://hg.mozilla.org/mozilla-central/rev/15d1960c419e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment on attachment 618856 [details] [diff] [review]
Translate the source correctly

Review of attachment 618856 [details] [diff] [review]:
-----------------------------------------------------------------

Let's fix this Web-facing regression ASAP
Attachment #618856 - Flags: approval-mozilla-beta?
Attachment #618856 - Flags: approval-mozilla-aurora?
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #12)
> Let's fix this Web-facing regression ASAP

What's the risk associated with this patch for a FF10 regression?
(In reply to Alex Keybl [:akeybl] from comment #13)
> What's the risk associated with this patch for a FF10 regression?

Should be very low risk, it's just changing the positioning of the image.
Comment on attachment 618856 [details] [diff] [review]
Translate the source correctly

sounds low risk enough, approving
Attachment #618856 - Flags: approval-mozilla-beta?
Attachment #618856 - Flags: approval-mozilla-beta+
Attachment #618856 - Flags: approval-mozilla-aurora?
Attachment #618856 - Flags: approval-mozilla-aurora+
Whiteboard: [qa+]
Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0

Verified in Ubuntu 12.04, Mac OS 10.6 and Windows 7 on Firefox 13 beta 6. Used attachment in comment 0.
Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20100101 Firefox/14.0

Verified in Ubuntu 12.04, Mac OS 10.8 and Windows 7 on Firefox 14 beta 7. Used attachment in comment 0.
You need to log in before you can comment on or make changes to this bug.