Closed Bug 749128 Opened 7 years ago Closed 7 years ago
Make sure to have JSContext before creating Tab
No description provided.
this shouldn't be terribly bad bug, since without the context safejscontext is used for JSON message creation.
Attachment #618605 - Flags: review?(justin.lebar+bug)
...but I want to fix the assertion mention in bug 749018
Comment on attachment 618605 [details] [diff] [review] patch This looks fine to me, but I don't feel comfortable reviewing this code.
Attachment #618605 - Flags: review?(justin.lebar+bug) → feedback+
This fixes my assertion, so I'm happy.
Comment on attachment 618605 [details] [diff] [review] patch - In TabChildGlobal::Init() mMessageManager = new nsFrameMessageManager(false, SendSyncMessageToParent, SendAsyncMessageToParent, nsnull, mTabChild, nsnull, - aTabChild->GetJSContext()); + mTabChild->GetJSContext()); } Should we assert here that this is not called more than once? r=jst either way.
Attachment #618605 - Flags: review?(jst) → review+
I can add an assert
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.