749128 - Make sure to have JSContext before creating TabChildGlobal

Status: RESOLVED FIXED

(Core :: IPC, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

this shouldn't be terribly bad bug, since without the context safejscontext
is used for JSON message creation.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

...but I want to fix the assertion mention in bug 749018

Comment 3

[Justin Lebar (not reading bugmail)]

Comment on attachment 618605 [details] [diff] [review]
patch

This looks fine to me, but I don't feel comfortable reviewing this code.

Comment 4

[Justin Lebar (not reading bugmail)]

This fixes my assertion, so I'm happy.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 618605 [details] [diff] [review]
patch

- In TabChildGlobal::Init()

   mMessageManager = new nsFrameMessageManager(false,
                                               SendSyncMessageToParent,
                                               SendAsyncMessageToParent,
                                               nsnull,
                                               mTabChild,
                                               nsnull,
-                                              aTabChild->GetJSContext());
+                                              mTabChild->GetJSContext());
 }

Should we assert here that this is not called more than once?

r=jst either way.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I can add an assert

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/dca63f21e6d2