749133 - E10S content-process crashes shouldn't trigger startup crash detection

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

The safe mode dialog kicks in too easily. For example when doing some
e10s related things, killing browser once makes the dialog to popup next time.
Perhaps value 4 would be more reasonable.

Comment 1

[Justin Dolske [:Dolske]]

What exactly does "doing some e10s related things" mean?

Comment 2

[Matthew N. [:MattN]]

(In reply to Olli Pettay [:smaug] from comment #0)
> The safe mode dialog kicks in too easily. For example when doing some
> e10s related things, killing browser once makes the dialog to popup next
> time.

Why don't we just fix this case so that it follows the number in the pref? Increasing the number doesn't actually fix the problem.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Justin Dolske [:Dolske] from comment #1)
> What exactly does "doing some e10s related things" mean?
Run E10s enabled Firefox (so that tabs are running in a separate process).
Or use the test.xul: firefox -chrome chrome://global/content/test-ipc.xul

Comment 4

[Justin Dolske [:Dolske]]

So it's content-process crashes that are causing this? We should just disable incrementing the crash-counter thing there.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Justin Dolske [:Dolske] from comment #4)
> So it's content-process crashes that are causing this?
I don't know. I don't know how we detect crashes.

Comment 6

[Josh Matthews [:jdm]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/startup/nsAppStartup.cpp#832

Comment 7

[Justin Dolske [:Dolske]]

Adjusting summary to match goal; I don't think we actually want to change the pref, just make content-process crashes not count towards startup crashed.