Closed Bug 749156 Opened 8 years ago Closed 7 years ago

Failure in /testPasswordManager/testPasswordNotificationBar.js | Expression "id("password-save-notification")" returned null. Anonymous == false

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set

Tracking

(firefox13 fixed, firefox14 fixed, firefox15 fixed)

VERIFIED FIXED
Tracking Status
firefox13 --- fixed
firefox14 --- fixed
firefox15 --- fixed

People

(Reporter: AlexLakatos, Assigned: AlexLakatos)

References

()

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(1 file)

TEST: /testPasswordManager/testPasswordNotificationBar.js::testPasswordNotification
ERROR: Expression "id("password-save-notification")" returned null. Anonymous == false 
WHEN: 2012-04-25
FIRST: 2012-04-25
FREQ: 3
BRANCHES: default

Something changed in popup-notification creation in Firefox.
On previous versions an element with id "password-save-notification" got created and after closing, still remained in the xul file. Not it is removed.
The test referenced the parentNode of the password notification. So I got the parent node directly, without referenced it via the child, since that gets removed.
Assignee: nobody → alex.lakatos
Status: NEW → ASSIGNED
Attachment #618634 - Flags: review?(anthony.s.hughes)
Comment on attachment 618634 [details] [diff] [review]
patch v1.0 [checked-in:default,aurora,beta]

Please pass reviews to Henrik from now on and keep Anthony for feedback requests, as of today. 

This is due to a 1 on 1 chat I had with Anthony yesterday on iRC. Thanks for the patch Alex!
Attachment #618634 - Flags: review?(anthony.s.hughes) → review?(hskupin)
(In reply to Maniac Vlad Florin (:vladmaniac) from comment #2)
> Please pass reviews to Henrik from now on and keep Anthony for feedback
> requests, as of today. 

No, that's not only me. It will be everyone from the Automation Developer team. As for now Dave and me. So please split it up between us.

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/9e935620e762

Please check if it fixes the failure and also land on aurora today.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 618634 [details] [diff] [review]
patch v1.0 [checked-in:default,aurora,beta]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/268ef8d52d34 (mozilla-aurora)
Attachment #618634 - Attachment description: patch v1.0 → patch v1.0 [checked-in:default,aurora]
Verified this did not fail today on Nightly.
Status: RESOLVED → VERIFIED
Keywords: checkin-needed
Anthony, please use the new status fields to mark where a patch has been checked in. Thanks.
Comment on attachment 618634 [details] [diff] [review]
patch v1.0 [checked-in:default,aurora,beta]

I noticed this failure happening on Beta so I landed the patch:

http://hg.mozilla.org/qa/mozmill-tests/rev/fb18a4382b34 (mozilla-beta)

See:
http://mozmill-ondemand.blargon7.com/#/functional/report/c2b72632f20450b6d99d14c709b017e5
Attachment #618634 - Attachment description: patch v1.0 [checked-in:default,aurora] → patch v1.0 [checked-in:default,aurora,beta]
Please do not reopen a bug which has been fixed a long time ago. The new failure is totally disconnected from the old issue we had to fix here. Please file a new bug for.
Status: REOPENED → RESOLVED
Closed: 8 years ago7 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.