Closed Bug 749278 Opened 12 years ago Closed 12 years ago

Rename "Script Debugger" to "Debugger"?

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Version:
12 Branch
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 15

People

(Reporter: vporof, Assigned: espadrine)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 3 obsolete files)

Rename + label → label2
3.01 KB, patch
rcampbell
: review+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → rcampbell
Priority: -- → P3
Assignee: rcampbell → thaddee.tyl

        Attachment #624056 -
        Flags: review?(rcampbell)

    
    

    
  
Comment on attachment 624056 [details] [diff] [review]
Renamed "Script Debugger" to "Debugger".

in debugger.dtd:

 <!-- LOCALIZATION NOTE (debuggerMenu.label): This is the label for the
   -  application menu item that opens the debugger UI. -->
-<!ENTITY debuggerMenu.label          "Script Debugger">
+<!ENTITY debuggerMenu.label          "Debugger">

Please rename the ENTITY. You can use debuggerMenu.label2 or similar.

        Attachment #624056 -
        Flags: review?(rcampbell) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Rename + label → label2 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #624056 -
        Attachment is obsolete: true

        Attachment #624062 -
        Flags: review?(rcampbell)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Rename + label → label2 (obsolete)
        — 
          — Splinter Review
      

    


  
I also renamed it in the properties file.

        Attachment #624062 -
        Attachment is obsolete: true

        Attachment #624062 -
        Flags: review?(rcampbell)

        Attachment #624078 -
        Flags: review?(rcampbell)

    
    

    
  
Comment on attachment 624078 [details] [diff] [review]
Rename + label → label2

you need to update the references to point to the new entity name in browser-appmenu.inc and browser-menubar.inc.

        Attachment #624078 -
        Flags: review?(rcampbell) → review-

    
    

    
  


  
Also modified browser/base/content inc files.

        Attachment #624078 -
        Attachment is obsolete: true

        Attachment #624095 -
        Flags: review?(rcampbell)

    
    

    
  
Comment on attachment 624095 [details] [diff] [review]
Rename + label → label2

Looks good! Thanks!

        Attachment #624095 -
        Flags: review?(rcampbell) → review+

    
    

    
  
Congratulations on landing your first patch!

https://hg.mozilla.org/integration/fx-team/rev/adddf0801b2b
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]

    
    

    
  
Thanks ;)
Status: ASSIGNED → NEW

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/adddf0801b2b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: