The default bug view has changed. See this FAQ.

Rename "Script Debugger" to "Debugger"?

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: espadrine)

Tracking

12 Branch
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
Assignee: nobody → rcampbell
Priority: -- → P3
Assignee: rcampbell → thaddee.tyl
(Assignee)

Comment 1

5 years ago
Created attachment 624056 [details] [diff] [review]
Renamed "Script Debugger" to "Debugger".
Attachment #624056 - Flags: review?(rcampbell)
Comment on attachment 624056 [details] [diff] [review]
Renamed "Script Debugger" to "Debugger".

in debugger.dtd:

 <!-- LOCALIZATION NOTE (debuggerMenu.label): This is the label for the
   -  application menu item that opens the debugger UI. -->
-<!ENTITY debuggerMenu.label          "Script Debugger">
+<!ENTITY debuggerMenu.label          "Debugger">

Please rename the ENTITY. You can use debuggerMenu.label2 or similar.
Attachment #624056 - Flags: review?(rcampbell) → review-
(Assignee)

Comment 3

5 years ago
Created attachment 624062 [details] [diff] [review]
Rename + label → label2
Attachment #624056 - Attachment is obsolete: true
Attachment #624062 - Flags: review?(rcampbell)
(Assignee)

Comment 4

5 years ago
Created attachment 624078 [details] [diff] [review]
Rename + label → label2

I also renamed it in the properties file.
Attachment #624062 - Attachment is obsolete: true
Attachment #624062 - Flags: review?(rcampbell)
Attachment #624078 - Flags: review?(rcampbell)
Comment on attachment 624078 [details] [diff] [review]
Rename + label → label2

you need to update the references to point to the new entity name in browser-appmenu.inc and browser-menubar.inc.
Attachment #624078 - Flags: review?(rcampbell) → review-
(Assignee)

Comment 6

5 years ago
Created attachment 624095 [details] [diff] [review]
Rename + label → label2

Also modified browser/base/content inc files.
Attachment #624078 - Attachment is obsolete: true
Attachment #624095 - Flags: review?(rcampbell)
Comment on attachment 624095 [details] [diff] [review]
Rename + label → label2

Looks good! Thanks!
Attachment #624095 - Flags: review?(rcampbell) → review+
Congratulations on landing your first patch!

https://hg.mozilla.org/integration/fx-team/rev/adddf0801b2b
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 9

5 years ago
Thanks ;)
Status: ASSIGNED → NEW
https://hg.mozilla.org/mozilla-central/rev/adddf0801b2b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.