749357 - TiledThebesLayerOGL can draw un-rendered areas of tiles

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Lord [:cwiiis]]

When running native android fennec with the patch on bug 607417, and with MOZ_FIXED_POSITION_LAYERS defined, fixed position layers draw areas of the tile that have not been rendered into (and should not be visible).

This can be seen on http://bradfrostweb.com/demo/fixed/index.html

Turning off tiled layer drawing fixes the problem. Turning off retained tiles makes no difference to the behaviour.

Comment 1

[Benoit Girard (:BenWa)]

Most likely because we're not respecting the region, should be an easy fix. I'll look at this soon.

Comment 2

[Benoit Girard (:BenWa)]

Taking the bug. This should be at least a release blocker.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 4

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 619162 [details] [diff] [review]
patch

Review of attachment 619162 [details] [diff] [review]:
-----------------------------------------------------------------

This looks correct to me.

Comment 6

[Chris Lord [:cwiiis]]

Attachment: Rebased patch

I r+'d the original patch, but it doesn't apply to current central - here it is, rebased (non-trivial, so this should be reviewed if it's used). Works, but I've only done extremely limited testing.

Comment 7

[Benoit Girard (:BenWa)]

Rebase looks good to me. Landing.

Comment 8

[Benoit Girard (:BenWa)]

Comment on attachment 619196 [details] [diff] [review]
Rebased patch

[Approval Request Comment]
Regression caused by (bug #): Bug 739679 - Add a Shadowable TiledThebesLayer implementation
User impact if declined: Visual glitches for complex layers (non rectangular).
Testing completed (on m-c, etc.): Tested locally to fix a few test cases. I'm looking to allow a few days of bake time on m-c.
Risk to taking this patch (and alternatives if risky): Low, changed the draw region to reflect accurately the input value.
String changes made by this patch: None

Recommending a few days of bake time on m-c to be certain this fixes the problem to make sure we only need to uplift on patch for this problem.

Comment 10

[JP Rosevear [:jpr]]

Is there a link to the inbound changeset?

Comment 11

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b46705ba525

Comment 12

[Tony Chung [:tchung]]

Verified fixed on brad's aurora try build.  

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c3deb5626819

Comment 13

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/72d39007162f

Comment 14

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5b46705ba525