749366 - Remove unused and mostly bogus size argument from Describe{RefCounted,GCed}Node CC callback

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: WIP

I should probably remove the renaming I did of the appallingly named "foo" local variable.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 1: remove the arguments

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 2: remove the now unused JSContextSize

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 655379 [details] [diff] [review]
part 1: remove the arguments

Try run looked okay.  Kind of a shame we don't have some better way to encapsulate Traverses that want to specify their own name.

https://tbpl.mozilla.org/?tree=Try&rev=9dd920702889

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 655380 [details] [diff] [review]
part 2: remove the now unused JSContextSize

This function was added by Ms2ger to remove jscntxt.h (or whatever) from the exported JS headers, but it isn't needed any more after this patch, so it makes sense to remove it, I think.

Comment 6

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/61efc4bbf95b
https://hg.mozilla.org/integration/mozilla-inbound/rev/65e30427c102

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/61efc4bbf95b
https://hg.mozilla.org/mozilla-central/rev/65e30427c102