Closed Bug 749366 Opened 8 years ago Closed 8 years ago

Remove unused and mostly bogus size argument from Describe{RefCounted,GCed}Node CC callback

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Blocks: CleanupCC
Attached patch WIP (obsolete) — Splinter Review
I should probably remove the renaming I did of the appallingly named "foo" local variable.
Assignee: nobody → continuation
Attachment #618848 - Attachment is obsolete: true
Comment on attachment 655379 [details] [diff] [review]
part 1: remove the arguments

Try run looked okay.  Kind of a shame we don't have some better way to encapsulate Traverses that want to specify their own name.

https://tbpl.mozilla.org/?tree=Try&rev=9dd920702889
Attachment #655379 - Flags: review?(bugs)
Comment on attachment 655380 [details] [diff] [review]
part 2: remove the now unused JSContextSize

This function was added by Ms2ger to remove jscntxt.h (or whatever) from the exported JS headers, but it isn't needed any more after this patch, so it makes sense to remove it, I think.
Attachment #655380 - Flags: review?(n.nethercote)
Attachment #655380 - Flags: review?(n.nethercote) → review+
Attachment #655379 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/61efc4bbf95b
https://hg.mozilla.org/mozilla-central/rev/65e30427c102
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.