Last Comment Bug 749366 - Remove unused and mostly bogus size argument from Describe{RefCounted,GCed}Node CC callback
: Remove unused and mostly bogus size argument from Describe{RefCounted,GCed}No...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla18
Assigned To: Andrew McCreight [:mccr8]
:
:
Mentors:
Depends on:
Blocks: CleanupCC
  Show dependency treegraph
 
Reported: 2012-04-26 14:00 PDT by Andrew McCreight [:mccr8]
Modified: 2012-08-27 19:18 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP (21.11 KB, patch)
2012-04-26 16:35 PDT, Andrew McCreight [:mccr8]
no flags Details | Diff | Splinter Review
part 1: remove the arguments (22.03 KB, patch)
2012-08-25 17:40 PDT, Andrew McCreight [:mccr8]
bugs: review+
Details | Diff | Splinter Review
part 2: remove the now unused JSContextSize (1.68 KB, patch)
2012-08-25 17:40 PDT, Andrew McCreight [:mccr8]
n.nethercote: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2012-04-26 14:00:25 PDT

    
Comment 1 Andrew McCreight [:mccr8] 2012-04-26 16:35:40 PDT
Created attachment 618848 [details] [diff] [review]
WIP

I should probably remove the renaming I did of the appallingly named "foo" local variable.
Comment 2 Andrew McCreight [:mccr8] 2012-08-25 17:40:03 PDT
Created attachment 655379 [details] [diff] [review]
part 1: remove the arguments
Comment 3 Andrew McCreight [:mccr8] 2012-08-25 17:40:23 PDT
Created attachment 655380 [details] [diff] [review]
part 2: remove the now unused JSContextSize
Comment 4 Andrew McCreight [:mccr8] 2012-08-26 19:21:31 PDT
Comment on attachment 655379 [details] [diff] [review]
part 1: remove the arguments

Try run looked okay.  Kind of a shame we don't have some better way to encapsulate Traverses that want to specify their own name.

https://tbpl.mozilla.org/?tree=Try&rev=9dd920702889
Comment 5 Andrew McCreight [:mccr8] 2012-08-26 19:22:32 PDT
Comment on attachment 655380 [details] [diff] [review]
part 2: remove the now unused JSContextSize

This function was added by Ms2ger to remove jscntxt.h (or whatever) from the exported JS headers, but it isn't needed any more after this patch, so it makes sense to remove it, I think.

Note You need to log in before you can comment on or make changes to this bug.