74937 - Confirm move to trash dialog doesn't appear when drag and drop folder to trash.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Wesley George]

<summary>
Confirm move to trash dialog doesn't appear when drag and drop folder to trash.

<environment>
build 04-02-04 + Win2000, Mac OS 9.04

<repro steps>
1. open mail
2. go to edit|preferences|mail and newsgroups, check checkbox "confirm when 
moving folders to the trash"
3. create a test folder on a mail server
4. drag and drop that the test folder to the Trash

<Result:>
No confirm dialog appears.

<Expected result:>
Confirm dialog should appear, asking: "Are you sure you want to move the 
selected folder into the Trash?"

Note:
Confirm dialog appears when right clicking on test folder and selecting delete 
folder from the context menu.

Comment 1

[John Levon]

see bug 62322, bug 24279.

Probably dupe of one of those

Comment 2

[Sheela Ravindran]

confirming this behavior on both win32 and mac os 9.04/ os x

When you drag and drop a folder no prompt.  This bug is not a duplicate.  We 
should prompt the user when we drag and drop like we do with context menu and 
edit|file menu item.  This behavior is present on the branch builds as well.

Comment 3

[Navin Gupta]

taking

Comment 4

[jglick]

>2. go to edit|preferences|mail and newsgroups, check checkbox "confirm when 
>moving folders to the trash"

With this pref checked, user should get the confirmation dialog when dragging 
folders to Trash.

Comment 5

[Navin Gupta]

Attachment: proposed fix

The fix is to move the confirm folder deletion logic to copyFolderLocal (where
we actually move the folder).

Comment 6

[Navin Gupta]

Cavin, David, Can I get reviews ? thx.

Comment 7

[David :Bienvenu]

Comment on attachment 91290 [details] [diff] [review]
proposed fix

sr=bienvenu

Comment 8

[Cavin Song]

Comment on attachment 91290 [details] [diff] [review]
proposed fix

r=cavin.

Comment 9

[Navin Gupta]

fixed

Comment 10

[Sheela Ravindran]

Drag N drop a local or pop folder to trash now prompts when pref" confirm when 
moving folders to trash is checked.

verified,
2002-09-11-10 -win98
2002-09-11-05 -linux rh 6.2
2002-09-11-03 -mac os x

This does not work for imap folders. No prompt when you DND imap folders to 
trash. Will log a seperate bug for that.