Closed
Bug 74951
Opened 25 years ago
Closed 23 years ago
[FIXr][RR/RFC]body stays "inline" after 'display' style changed to "block"
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
VERIFIED
FIXED
mozilla1.3alpha
People
(Reporter: dbaron, Assigned: bzbarsky)
References
Details
(Keywords: css2, testcase)
Attachments
(4 files)
|
354 bytes,
text/html
|
Details | |
|
442 bytes,
text/html
|
Details | |
|
6.69 KB,
image/png
|
Details | |
|
2.08 KB,
patch
|
caillon
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
screenshot ( kmeleon 0.5 after pressing inline! and block! with attachment 61900)
DESCRIPTION: In the testcase from bug 53251, body's margin is not restored when
its display is changed from "inline" to "block".
STEPS TO REPRODUCE:
METHOD 1:
* load http://bugzilla.mozilla.org/showattachment.cgi?attach_id=15041
* click button twice
METHOD 2:
* load attached testcase
* click "Inline", then "Block"
ACTUAL RESULTS:
* margin around button and text disappears after pressing (button once /
"Inline") and never reappears
EXPECTED RESULTS:
* margin around button and text should return to the way it started after
pressing the button the second time.
BUGGY IN:
* current Linux build
|
Reporter | |
Comment 1•25 years ago
|
||
|
||
Comment 2•25 years ago
|
||
Moved to Style System
Component: Layout → Style System
Target Milestone: --- → Future
not a table specfic bug, reassigning to owner.
Assignee: karnaze → dbaron
QA Contact: petersen → ian
|
|
Reporter | |
Comment 4•24 years ago
|
||
Hmm, this testcase now crashes as well.
build 2001121508 win32
1. Don't know if it is related to this bug but if I put a
style="display:inline;" on the <body> of the testcase nothing is displayed
unless I remove <p> foo </p>. Interestingly changing display to "inline" via
body.style.display does not hide everything.
2. Another thing if I remove <p> foo </p> mozilla nolonger crashes.
I used kmeleon0.5 to test this (moz0.9.4 I think) and it turns out that
something really weird is going on. <body> never really changes back to "block"
even after it is set. I'll post another testcase to show.
crash talkback IDs TB551406H TB551344Q
OS: Linux → All
Summary: body margin not restored after 'display' style changed → body stays "inline" after 'display' style changed to "block"
|
||
Comment 8•24 years ago
|
||
testcases no longer crash, but the original behavior is still happening with
latest nightly build.
Jake
|
||
Comment 9•24 years ago
|
||
Testcases don't crashing: Key: -crash,+testcase Sev: cri -> nor
|
|
Reporter | |
Updated•24 years ago
|
Status: NEW → ASSIGNED
Summary: body stays "inline" after 'display' style changed to "block" → [RR/RFC]body stays "inline" after 'display' style changed to "block"
|
|
||
Comment 10•24 years ago
|
||
cc'ing myself
|
||
Comment 11•24 years ago
|
||
Reconfirmed using FizzillaCFM/2002071208. Setting Platform=All.
Hardware: PC → All
|
|
Assignee | |
Comment 12•23 years ago
|
||
This has been boucing about in my tree for months. May as well get it checked
in under the auspices of this bug (the problem is basically an ib problem).
|
|
Assignee | |
Comment 13•23 years ago
|
||
may as well take...
Assignee: dbaron → bzbarsky
Status: ASSIGNED → NEW
|
|
Reporter | |
Comment 14•23 years ago
|
||
Comment on attachment 102410 [details] [diff] [review]
patch
r/sr=dbaron
Attachment #102410 -
Flags: superreview+
|
|
Reporter | |
Comment 15•23 years ago
|
||
(BTW, any ideas on a better name for ReconstructDocElementHierarchy? The name
should take into account that it doesn't reconstruct the viewport / canvas /
scrollframe (roughly).)
|
|
||
Comment 16•23 years ago
|
||
Comment on attachment 102410 [details] [diff] [review]
patch
r=caillon
Attachment #102410 -
Flags: review+
|
|
Assignee | |
Comment 17•23 years ago
|
||
ReconstructAllContentFrames?
Priority: P2 → P1
Summary: [RR/RFC]body stays "inline" after 'display' style changed to "block" → [FIX][RR/RFC]body stays "inline" after 'display' style changed to "block"
Target Milestone: Future → mozilla1.3alpha
|
|
Assignee | |
Updated•23 years ago
|
Summary: [FIX][RR/RFC]body stays "inline" after 'display' style changed to "block" → [FIXr][RR/RFC]body stays "inline" after 'display' style changed to "block"
|
|
Assignee | |
Comment 18•23 years ago
|
||
fix checked in for 1.3a
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
|
||
Comment 19•23 years ago
|
||
i still see this bug on winXP and Linux trunk builds 2003-02-17
re-opening
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 20•23 years ago
|
||
Hm... indeed, this is not working in a vanilla build. It's working in all my
other builds (which have various variants of the patch for bug 171830 in them).
So marking dependent on that; will retest once that lands.
Madhur, thanks!
Depends on: 171830
|
|
Assignee | |
Comment 21•23 years ago
|
||
Fixed by bug 171830.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
|
|
||
Comment 22•23 years ago
|
||
This time it is fixed :-)
Verifying on winXP , Linux and MacosX platforms with 03-31-2003 trunk builds
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•