IEProfileMigrator.js and SafariProfileMigrator.js are always in the components manifest

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Migration
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

13 Branch
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox12 unaffected, firefox13 unaffected, firefox14 affected)

Details

Attachments

(1 attachment)

On Mac, there is no IEProfileMigrator.js.
On Linux, there is neither.

Yet, in both builds, they both are in the components manifest.
Assignee: nobody → mh+mozilla
status-firefox12: --- → unaffected
status-firefox13: --- → unaffected
status-firefox14: --- → affected
Created attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed
Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed

Review of attachment 618955 [details] [diff] [review]:
-----------------------------------------------------------------

should be safe to backport to 13 too, so please get approval and do :)
Attachment #618955 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9150ab0f7bea
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/9150ab0f7bea
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
The commit message is misleading because we can't detect "when they are installed" at build time. Something like this would be better:
"Only reference IE and Safari migrators in components manifest on supported operating systems."
It's "installed" in the "$(NSINSTALL)" sense.
(In reply to Marco Bonardo [:mak] from comment #2)
> should be safe to backport to 13 too, so please get approval and do :)

I actually meant "backport to 14"... Merge didn't help my numbering.
Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed

[Approval Request Comment]
Regression caused by: bug 710259 and bug 710895
User impact if declined: No real user impact, but Firefox uselessly tries to registers components that aren't there on Mac and Linux.
Testing completed (on m-c, etc.): Landed on m-c a couple days ago.
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #618955 - Flags: approval-mozilla-aurora?

Comment 9

5 years ago
Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed

[Triage Comment]
We don't typically take correctness fixes with no user impact.
Attachment #618955 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
You need to log in before you can comment on or make changes to this bug.