Consumed Alt key (i.e., preventDefault() is called) causes to activate menubar

RESOLVED FIXED in mozilla15

Status

()

Core
XP Toolkit/Widgets: Menus
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla15
x86_64
Windows 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

5.23 KB, patch
Neil Deakin (mostly unavailable until September)
: review+
Details | Diff | Splinter Review
1. Open the URL.
2. Press Alt key.

Then, the Alt keydown event is consumed by the blank page, but menu is activated. It shouldn't be activated by consumed event.

Alt+F works fine, it checks the defaultPrevented value.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Created attachment 622238 [details] [diff] [review]
Patch
Attachment #622238 - Flags: review?(enndeakin)
Comment on attachment 622238 [details] [diff] [review]
Patch

>+  result: function(testname) {
>+    ok(!document.getElementById("filemenu").openedWithKey, testname);
>+  },

Could you also add a line to check that the menu isn't open, so that an test failure will be caught here rather than at a later test. Same with the other test.
Attachment #622238 - Flags: review?(enndeakin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e52bf88f2f54
Target Milestone: --- → mozilla15

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e52bf88f2f54
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Blocks: 757330
Blocks: 708936
You need to log in before you can comment on or make changes to this bug.