Last Comment Bug 749563 - Consumed Alt key (i.e., preventDefault() is called) causes to activate menubar
: Consumed Alt key (i.e., preventDefault() is called) causes to activate menubar
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XP Toolkit/Widgets: Menus (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
:
:
Mentors:
data:text/html,<script>window.addEven...
Depends on:
Blocks: 708936 757330
  Show dependency treegraph
 
Reported: 2012-04-27 03:38 PDT by Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
Modified: 2013-02-08 08:39 PST (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (5.23 KB, patch)
2012-05-08 18:08 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
enndeakin: review+
Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2012-04-27 03:38:32 PDT
1. Open the URL.
2. Press Alt key.

Then, the Alt keydown event is consumed by the blank page, but menu is activated. It shouldn't be activated by consumed event.

Alt+F works fine, it checks the defaultPrevented value.
Comment 1 Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2012-05-08 18:08:07 PDT
Created attachment 622238 [details] [diff] [review]
Patch
Comment 2 Neil Deakin (away until Oct 3) 2012-05-09 10:48:09 PDT
Comment on attachment 622238 [details] [diff] [review]
Patch

>+  result: function(testname) {
>+    ok(!document.getElementById("filemenu").openedWithKey, testname);
>+  },

Could you also add a line to check that the menu isn't open, so that an test failure will be caught here rather than at a later test. Same with the other test.
Comment 3 Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2012-05-09 16:26:33 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/e52bf88f2f54
Comment 4 Ed Morley [:emorley] 2012-05-10 08:02:41 PDT
https://hg.mozilla.org/mozilla-central/rev/e52bf88f2f54

Note You need to log in before you can comment on or make changes to this bug.