Closed Bug 749582 Opened 8 years ago Closed 8 years ago

Fennec doesn't start in landscape mode

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 15
Tracking Status
firefox14 --- verified
firefox15 --- verified
blocking-fennec1.0 --- +

People

(Reporter: paul.feher, Assigned: Margaret)

Details

Attachments

(2 files)

Attached file Log file
Nightly/14.0a1 (2012-04-27)
Device: HTC Desire Z
OS: Android 2.3.3

Steps to reproduce:
Open Fennec app in landscape mode.

Expected result:
Nightly start with about:home page in view.

Actual results:
Nightly doesn't start, only a grey background is displayed.This is happening in 9 out of 10 tries.

NOTE:This issue This is not reproducible on HTC Desire (Android 2.2.2) Samsung Galaxy S2 (Android 2.3.4). Please see the log file attached.
mFormAssistPopup is null?
I also couldn't reproduce this on a Galaxy Nexus, but it looks like onConfigurationChanged() is getting called before initializing mFormAssistPopup, which means it's getting called before initialize(). I think a null check is the right fix for this problem.

We also call refreshActionBar() in onConfigurationChanged(), which references mBrowserToolbar, but that's initialized in onCreate(), so we shouldn't get a NPE in that case.
Assignee: nobody → margaret.leibovic
Attached patch patchSplinter Review
Attachment #619139 - Flags: review?(mark.finkle)
blocking-fennec1.0: --- → ?
Attachment #619139 - Flags: review?(mark.finkle) → review+
Comment on attachment 619139 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: startup crash on some devices
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): low risk (only adds a null check)
String changes made by this patch: n/a
Attachment #619139 - Flags: approval-mozilla-aurora?
http://hg.mozilla.org/mozilla-central/rev/915cb011619f
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Let's find out if this is blocking fennec 1.0 before approving for Aurora 14.
Comment on attachment 619139 [details] [diff] [review]
patch

[Triage Comment]
Still hasn't gone through blocking triage, but I can't imagine we'd want to leave this very reproducible startup crash unfixed, so I'm just going to approve for Aurora 14.
Attachment #619139 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:
Nightly Fennec 15.0a1 (2012-05-07)
Aurora Fennec 14.0a2 (2012-05-07)
Device: HTC Desire Z
OS: Android 2.3.3

Using the initial STR.
Status: RESOLVED → VERIFIED
blocking-fennec1.0: ? → +
You need to log in before you can comment on or make changes to this bug.