749582 - Fennec doesn't start in landscape mode

Status: VERIFIED FIXED

Description

[Paul Feher]

Created attachment 618997 [details]
Log file

Nightly/14.0a1 (2012-04-27)
Device: HTC Desire Z
OS: Android 2.3.3

Steps to reproduce:
Open Fennec app in landscape mode.

Expected result:
Nightly start with about:home page in view.

Actual results:
Nightly doesn't start, only a grey background is displayed.This is happening in 9 out of 10 tries.

NOTE:This issue This is not reproducible on HTC Desire (Android 2.2.2) Samsung Galaxy S2 (Android 2.3.4). Please see the log file attached.

Comment 1

[Kartikaya Gupta (away Jan 12-26; email:[e-mail])]

mFormAssistPopup is null?

Comment 2

[:Margaret Leibovic]

I also couldn't reproduce this on a Galaxy Nexus, but it looks like onConfigurationChanged() is getting called before initializing mFormAssistPopup, which means it's getting called before initialize(). I think a null check is the right fix for this problem.

We also call refreshActionBar() in onConfigurationChanged(), which references mBrowserToolbar, but that's initialized in onCreate(), so we shouldn't get a NPE in that case.

Comment 3

[:Margaret Leibovic]

Created attachment 619139 [details] [diff] [review]
patch

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/915cb011619f

Comment 5

[:Margaret Leibovic]

Comment on attachment 619139 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: startup crash on some devices
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): low risk (only adds a null check)
String changes made by this patch: n/a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/915cb011619f

Comment 7

[Alex Keybl [:akeybl]]

Let's find out if this is blocking fennec 1.0 before approving for Aurora 14.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 619139 [details] [diff] [review]
patch

[Triage Comment]
Still hasn't gone through blocking triage, but I can't imagine we'd want to leave this very reproducible startup crash unfixed, so I'm just going to approve for Aurora 14.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6135b86479ac

Comment 10

[Paul Feher]

Verified fixed on:
Nightly Fennec 15.0a1 (2012-05-07)
Aurora Fennec 14.0a2 (2012-05-07)
Device: HTC Desire Z
OS: Android 2.3.3

Using the initial STR.