749589 - Less-leaky classinfo for XTF

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: WIP

Classinfo shouldn't keep the object alive.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 619016 [details] [diff] [review]
WIP

Bill, could you test this?
It should fix the leak you saw where keeping classinfo alive ends up
keeping element alive.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=1e3e3ac9452f

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Jst, review ping. I believe this block iGC.

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Olli Pettay [:smaug] from comment #5)
> Jst, review ping. I believe this block iGC.

No, it doesn't.  This is just an existing leak that we've ignored for years that Bill happened to notice while investigating IGC leaks, if I understand correctly.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Oh, I thought iGC+xpcshell tests were leaking because of this.

But anyhow, Bill, you could test this.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

er, could you...

Comment 9

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

(In reply to Olli Pettay [:smaug] from comment #7)
> Oh, I thought iGC+xpcshell tests were leaking because of this.

They are, but non-iGC+xpcshell are too :-)

Comment 10

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Yeah, this fixes the leak. Thanks.

This doesn't block IGC. It's a leak we found while trying to debug the IGC leak. As Rafael said, it leaks on trunk right now.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/22a58090fa70