749661 - Workaround yaffs2 readdir bug

Status: REOPENED

(Core :: XPCOM, defect)

Description

[Michael Wu [:mwu]]

Attachment: Workaround yaffs2 readdir bug

yaffs2 has issues with readdir which can cause infinite loops when used with indexeddb. We can workaround this.

Comment 1

[Doug Turner (:dougt)]

mwu, instead can we use statfs() to determine if the directory to enumerate is on yaffs2?

Comment 2

[Michael Wu [:mwu]]

Attachment: Workaround yaffs2 readdir bug, v2

This checks the filesystem type

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 619546 [details] [diff] [review]
Workaround yaffs2 readdir bug, v2

Review of attachment 619546 [details] [diff] [review]:
-----------------------------------------------------------------

#ifdef ANDROID -> YAFFS2_WORKAROUND

This is special cased only for the /data mount point.  That is fine for now - just add a comment about that.  Others might be running into this problem on non-android systems.

Comment 4

[Michael Wu [:mwu]]

https://hg.mozilla.org/mozilla-central/rev/3812e7c1b642

Comment 5

[Michael Wu [:mwu]]

Didn't stick.

https://hg.mozilla.org/mozilla-central/rev/6bffe5985546

Comment 6

[Michael Wu [:mwu]]

Not working on this, and the FFOX devices we're shipping on either don't have this FS or have the issue patched out. A fix would probably still be good for Firefox on Android, though.