Closed Bug 749672 Opened 9 years ago Closed 9 years ago

Focus Cancel by default in the “Reset Firefox” (resetProfileAndRestart) button’s dialog of about:support

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla22

People

(Reporter: Aleksej, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Keywords: dataloss)

Attachments

(1 file)

It is too easy to remove configuration, like site preferences, with the “Reset Firefox” feature.

E.g. (DATALOSSY STEPS!):

1. Go to about:support (Help → Troubleshooting information).

2. Press “Reset Firefox”.
3. Press Enter.

…which can be “accomplished” quickly without looking by doing this:
2. Press “Tab”.
3. Press Enter twice.


Actual results:
Site preferences are lost.


Expected results:
It is not that easy to do that.


Although a similar feature, “Clear Recent History”, activates the clear button by default, “Site Preferences” and “Offline Website Data” checkboxes are unset by default.
Attached patch patchSplinter Review
I think it's reasonable to make the Cancel button the default button for such a destructive action.
Attachment #729169 - Flags: review?(bmcbride)
Component: Untriaged → General
OS: Linux → All
Hardware: x86_64 → All
Product: Firefox → Toolkit
Comment on attachment 729169 [details] [diff] [review]
patch

Review of attachment 729169 [details] [diff] [review]:
-----------------------------------------------------------------

Uh, yes.
Attachment #729169 - Flags: review?(bmcbride) → review+
Assignee: nobody → adw
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/3c41ff7181db
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Reproduced in Nightly 15.0a1 on windows 8.1 (64 bit)

This Bug is now verified as fixed on Latest Firefox nightly 47.0a1
(Build ID: 20160307030208)
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Verified fixed on 2016-03-17-08-08-00-mozilla-central-firefox-48.0a1.ru.linux-x86_64, too.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.