749788 - Various errors exist in JNI code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Various errors I found: missing null checks and potentially using the wrong JNIEnv for the thread. Also a bad variable initialization.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d619155c69b

Half of the patch was rendered unnecessary by snorp's patch from bug 727116 so this only has the other half.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/2d619155c69b

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 619165 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): various
User impact if declined: future patches (flash-related) may not apply cleanly
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): not much risk, mobile-only
String changes made by this patch: none

Comment 4

[Alex Keybl [:akeybl]]

Let's find out if this is blocking fennec 1.0 before approving for Aurora 14. My intuition tells me it's not a blocker, but still OK to take. I'd like clarification though.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5dc031d43ff3