Closed Bug 749788 Opened 8 years ago Closed 8 years ago

Various errors exist in JNI code

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 15
Tracking Status
firefox14 --- fixed
firefox15 --- fixed
blocking-fennec1.0 --- +

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Various errors I found: missing null checks and potentially using the wrong JNIEnv for the thread. Also a bad variable initialization.
Attachment #619165 - Flags: review?(blassey.bugs)
Attachment #619165 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d619155c69b

Half of the patch was rendered unnecessary by snorp's patch from bug 727116 so this only has the other half.
Target Milestone: --- → Firefox 15
http://hg.mozilla.org/mozilla-central/rev/2d619155c69b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 619165 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): various
User impact if declined: future patches (flash-related) may not apply cleanly
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): not much risk, mobile-only
String changes made by this patch: none
Attachment #619165 - Flags: approval-mozilla-aurora?
Let's find out if this is blocking fennec 1.0 before approving for Aurora 14. My intuition tells me it's not a blocker, but still OK to take. I'd like clarification though.
blocking-fennec1.0: --- → ?
Attachment #619165 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 694992
blocking-fennec1.0: ? → +
You need to log in before you can comment on or make changes to this bug.