Created attachment 619165 [details] [diff] [review]
Various errors I found: missing null checks and potentially using the wrong JNIEnv for the thread. Also a bad variable initialization.
Half of the patch was rendered unnecessary by snorp's patch from bug 727116 so this only has the other half.
Comment on attachment 619165 [details] [diff] [review]
[Approval Request Comment]
Regression caused by (bug #): various
User impact if declined: future patches (flash-related) may not apply cleanly
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): not much risk, mobile-only
String changes made by this patch: none
Let's find out if this is blocking fennec 1.0 before approving for Aurora 14. My intuition tells me it's not a blocker, but still OK to take. I'd like clarification though.
*** Bug 694992 has been marked as a duplicate of this bug. ***