Various errors exist in JNI code

RESOLVED FIXED in Firefox 14

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
Firefox 15
All
Android
Points:
---

Firefox Tracking Flags

(firefox14 fixed, firefox15 fixed, blocking-fennec1.0 +)

Details

Attachments

(1 attachment)

Created attachment 619165 [details] [diff] [review]
Patch

Various errors I found: missing null checks and potentially using the wrong JNIEnv for the thread. Also a bad variable initialization.
Attachment #619165 - Flags: review?(blassey.bugs)
Attachment #619165 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d619155c69b

Half of the patch was rendered unnecessary by snorp's patch from bug 727116 so this only has the other half.
status-firefox15: --- → fixed
Target Milestone: --- → Firefox 15
http://hg.mozilla.org/mozilla-central/rev/2d619155c69b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 619165 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): various
User impact if declined: future patches (flash-related) may not apply cleanly
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): not much risk, mobile-only
String changes made by this patch: none
Attachment #619165 - Flags: approval-mozilla-aurora?

Comment 4

5 years ago
Let's find out if this is blocking fennec 1.0 before approving for Aurora 14. My intuition tells me it's not a blocker, but still OK to take. I'd like clarification though.
blocking-fennec1.0: --- → ?
Attachment #619165 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/5dc031d43ff3
status-firefox14: --- → fixed
Duplicate of this bug: 694992
blocking-fennec1.0: ? → +
You need to log in before you can comment on or make changes to this bug.