Closed
Bug 749795
Opened 13 years ago
Closed 13 years ago
Getter for NPNVprivateModeBool is broken with OOPP
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: jdm, Assigned: jdm)
References
Details
Attachments
(1 file)
|
3.53 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
I'm glad I decided to add a test for bug 748752, since it exposed that the code is completely broken. Retrieving the document (http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsNPAPIPlugin.cpp#2139) fails, since npp is null (http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/PluginModuleParent.cpp#978). Josh, what's the correct way to fix this?
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Comment 1•13 years ago
|
||
It looks like the privateModeBool handling will need to move to PluginInstance*, similar to pluginElementNPObject and pluginWindowNPObject.
|
|
Assignee | |
Comment 2•13 years ago
|
||
That was easy. The test now passes.
Attachment #619505 -
Flags: review?(joshmoz)
Comment on attachment 619505 [details] [diff] [review]
Use neglected code that properly obtains private browsing mode in plugins.
Review of attachment 619505 [details] [diff] [review]:
-----------------------------------------------------------------
Did you intend to include the change to test_domstorage_aboutpages.js?
Attachment #619505 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Nein. I'll take that out when landing.
|
|
Assignee | |
Comment 5•13 years ago
|
||
Assignee: nobody → josh
Flags: in-testsuite+
Target Milestone: --- → mozilla15
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•