The default bug view has changed. See this FAQ.

Getter for NPNVprivateModeBool is broken with OOPP

RESOLVED FIXED in mozilla15

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

Trunk
mozilla15
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I'm glad I decided to add a test for bug 748752, since it exposed that the code is completely broken. Retrieving the document (http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsNPAPIPlugin.cpp#2139) fails, since npp is null (http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/PluginModuleParent.cpp#978). Josh, what's the correct way to fix this?
(Assignee)

Updated

5 years ago
Blocks: 463027, 748752
(Assignee)

Comment 1

5 years ago
It looks like the privateModeBool handling will need to move to PluginInstance*, similar to pluginElementNPObject and pluginWindowNPObject.
(Assignee)

Comment 2

5 years ago
Created attachment 619505 [details] [diff] [review]
Use neglected code that properly obtains private browsing mode in plugins.

That was easy. The test now passes.
Attachment #619505 - Flags: review?(joshmoz)

Comment 3

5 years ago
Comment on attachment 619505 [details] [diff] [review]
Use neglected code that properly obtains private browsing mode in plugins.

Review of attachment 619505 [details] [diff] [review]:
-----------------------------------------------------------------

Did you intend to include the change to test_domstorage_aboutpages.js?
Attachment #619505 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 4

5 years ago
Nein. I'll take that out when landing.
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/52abbd73ec2d
Assignee: nobody → josh
Flags: in-testsuite+
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/52abbd73ec2d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.