Closed Bug 749976 Opened 11 years ago Closed 11 years ago

Reduce the curve tolerance to match skia on mobile

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
blocking-fennec1.0 --- -

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

Attachments

(2 files)

Skia uses a value of 0.5
Whiteboard: [autoland-try: -b do -p all -u all -t all]
Whiteboard: [autoland-try: -b do -p all -u all -t all]
0.4 was causing small reftest failures. This is doesn't cause the failures and should still improve performance.
Attachment #626693 - Flags: review?(bgirard)
Attachment #626693 - Flags: review?(bgirard) → review+
Looks like there were still reftest failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9713cb1ed642
Here's the original landing:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50178ba811f2
Assignee: nobody → jmuizelaar
Try again:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e882879c853
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/2e882879c853
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Comment on attachment 626693 [details] [diff] [review]
Use a value of 0.2

[Approval Request Comment]
User impact if declined: Slower curve drawing performance. The spinning svg tiger goes from 6.5fps to 7.5fps on my phone
Testing completed (on m-c, etc.): Has been on m-c for a couple of days
Risk to taking this patch (and alternatives if risky): Mobile only, very low risk as it's just changing a constant.
String or UUID changes made by this patch: None
Attachment #626693 - Flags: approval-mozilla-aurora?
blocking-fennec1.0: --- → ?
blocking-fennec1.0: ? → -
Comment on attachment 626693 [details] [diff] [review]
Use a value of 0.2

[Triage Comment]
While this doesn't block release, the risk profile is low enough (and SVG usage uncommon enough) to take this on Aurora 14. Approved.
Attachment #626693 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.