Reduce the curve tolerance to match skia on mobile

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking-fennec1.0 -)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Skia uses a value of 0.5
(Assignee)

Comment 1

5 years ago
Created attachment 619335 [details] [diff] [review]
Use a value of 0.4
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try: -b do -p all -u all -t all]
Whiteboard: [autoland-try: -b do -p all -u all -t all]
(Assignee)

Comment 2

5 years ago
Created attachment 626693 [details] [diff] [review]
Use a value of 0.2

0.4 was causing small reftest failures. This is doesn't cause the failures and should still improve performance.
Attachment #626693 - Flags: review?(bgirard)

Updated

5 years ago
Attachment #626693 - Flags: review?(bgirard) → review+
(Assignee)

Comment 3

5 years ago
Looks like there were still reftest failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9713cb1ed642
(Assignee)

Comment 4

5 years ago
Here's the original landing:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50178ba811f2
Assignee: nobody → jmuizelaar
(Assignee)

Comment 5

5 years ago
Try again:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e882879c853
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/2e882879c853
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
(Assignee)

Comment 7

5 years ago
Comment on attachment 626693 [details] [diff] [review]
Use a value of 0.2

[Approval Request Comment]
User impact if declined: Slower curve drawing performance. The spinning svg tiger goes from 6.5fps to 7.5fps on my phone
Testing completed (on m-c, etc.): Has been on m-c for a couple of days
Risk to taking this patch (and alternatives if risky): Mobile only, very low risk as it's just changing a constant.
String or UUID changes made by this patch: None
Attachment #626693 - Flags: approval-mozilla-aurora?

Updated

5 years ago
blocking-fennec1.0: --- → ?
blocking-fennec1.0: ? → -

Comment 8

5 years ago
Comment on attachment 626693 [details] [diff] [review]
Use a value of 0.2

[Triage Comment]
While this doesn't block release, the risk profile is low enough (and SVG usage uncommon enough) to take this on Aurora 14. Approved.
Attachment #626693 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.