749976 - Reduce the curve tolerance to match skia on mobile

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Skia uses a value of 0.5

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use a value of 0.4

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use a value of 0.2

0.4 was causing small reftest failures. This is doesn't cause the failures and should still improve performance.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Looks like there were still reftest failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9713cb1ed642

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Here's the original landing:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50178ba811f2

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Try again:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e882879c853

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2e882879c853

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 626693 [details] [diff] [review]
Use a value of 0.2

[Approval Request Comment]
User impact if declined: Slower curve drawing performance. The spinning svg tiger goes from 6.5fps to 7.5fps on my phone
Testing completed (on m-c, etc.): Has been on m-c for a couple of days
Risk to taking this patch (and alternatives if risky): Mobile only, very low risk as it's just changing a constant.
String or UUID changes made by this patch: None

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 626693 [details] [diff] [review]
Use a value of 0.2

[Triage Comment]
While this doesn't block release, the risk profile is low enough (and SVG usage uncommon enough) to take this on Aurora 14. Approved.