Last Comment Bug 750053 - Simplify error handling around collapsed selections in editor
: Simplify error handling around collapsed selections in editor
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-29 06:02 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-05-18 02:49 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part a: Add nsISelection::Collapsed() (2.54 KB, patch)
2012-04-29 06:02 PDT, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
Details | Diff | Splinter Review
Part b: Stop using GetIsCollapsed in editor/libeditor (44.87 KB, patch)
2012-04-29 06:07 PDT, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-04-29 06:02:21 PDT
Created attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2012-04-29 06:07:25 PDT
Created attachment 619388 [details] [diff] [review]
Part b: Stop using GetIsCollapsed in editor/libeditor
Comment 2 :Ehsan Akhgari 2012-04-30 11:02:55 PDT
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()

Review of attachment 619387 [details] [diff] [review]:
-----------------------------------------------------------------

You need to rev the IID of nsISelection.
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2012-04-30 12:19:13 PDT
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()

Yes, and I will, but I'm not going to spend time merging uuid changes.
Comment 4 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-05-07 07:42:48 PDT
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()

>+++ b/content/base/public/nsISelection.idl
>@@ -72,16 +72,17 @@ interface nsISelection : nsISupports
update uuid

Note You need to log in before you can comment on or make changes to this bug.