Simplify error handling around collapsed selections in editor

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()
Attachment #619387 - Flags: review?(bugs)
(Assignee)

Comment 1

5 years ago
Created attachment 619388 [details] [diff] [review]
Part b: Stop using GetIsCollapsed in editor/libeditor
Attachment #619388 - Flags: review?(ehsan)
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()

Review of attachment 619387 [details] [diff] [review]:
-----------------------------------------------------------------

You need to rev the IID of nsISelection.
Attachment #619387 - Flags: review?(bugs) → review-
Attachment #619388 - Flags: review?(ehsan) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()

Yes, and I will, but I'm not going to spend time merging uuid changes.
Attachment #619387 - Flags: review- → review?(bugs)

Comment 4

5 years ago
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()

>+++ b/content/base/public/nsISelection.idl
>@@ -72,16 +72,17 @@ interface nsISelection : nsISupports
update uuid
Attachment #619387 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ba0cffcf1f6e
https://hg.mozilla.org/mozilla-central/rev/137ec8d18fe8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.