Closed
Bug 750053
Opened 13 years ago
Closed 13 years ago
Simplify error handling around collapsed selections in editor
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(2 files)
|
2.54 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
44.87 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #619387 -
Flags: review?(bugs)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #619388 -
Flags: review?(ehsan)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()
Review of attachment 619387 [details] [diff] [review]:
-----------------------------------------------------------------
You need to rev the IID of nsISelection.
Attachment #619387 -
Flags: review?(bugs) → review-
|
|
||
Updated•13 years ago
|
Attachment #619388 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()
Yes, and I will, but I'm not going to spend time merging uuid changes.
Attachment #619387 -
Flags: review- → review?(bugs)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 619387 [details] [diff] [review]
Part a: Add nsISelection::Collapsed()
>+++ b/content/base/public/nsISelection.idl
>@@ -72,16 +72,17 @@ interface nsISelection : nsISupports
update uuid
Attachment #619387 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba0cffcf1f6e
https://hg.mozilla.org/mozilla-central/rev/137ec8d18fe8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•