750062 - Assert preconditions in IsVisTextNode

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

I checked all the callers, and they get the preconditions right.

Comment 1

[(no longer active)]

Comment on attachment 619393 [details] [diff] [review]
Patch v1

Review of attachment 619393 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditor.cpp
@@ +4592,5 @@
>                              bool aSafeToAskFrames)
>  {
> +  MOZ_ASSERT(aNode);
> +  MOZ_ASSERT(aNode->NodeType() == nsIDOMNode::TEXT_NODE);
> +  MOZ_ASSERT(outIsEmptyNode);

Nit: aNode && outIsEmptyNode

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4fb0fa799d9e