Last Comment Bug 750062 - Assert preconditions in IsVisTextNode
: Assert preconditions in IsVisTextNode
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-29 06:59 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-05-05 10:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (4.34 KB, patch)
2012-04-29 06:59 PDT, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-04-29 06:59:28 PDT
Created attachment 619393 [details] [diff] [review]
Patch v1

I checked all the callers, and they get the preconditions right.
Comment 1 :Ehsan Akhgari 2012-04-30 11:01:32 PDT
Comment on attachment 619393 [details] [diff] [review]
Patch v1

Review of attachment 619393 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditor.cpp
@@ +4592,5 @@
>                              bool aSafeToAskFrames)
>  {
> +  MOZ_ASSERT(aNode);
> +  MOZ_ASSERT(aNode->NodeType() == nsIDOMNode::TEXT_NODE);
> +  MOZ_ASSERT(outIsEmptyNode);

Nit: aNode && outIsEmptyNode
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-05-05 10:29:38 PDT
https://hg.mozilla.org/mozilla-central/rev/4fb0fa799d9e

Note You need to log in before you can comment on or make changes to this bug.