Assert preconditions in IsVisTextNode

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 619393 [details] [diff] [review]
Patch v1

I checked all the callers, and they get the preconditions right.
Attachment #619393 - Flags: review?(ehsan)
Comment on attachment 619393 [details] [diff] [review]
Patch v1

Review of attachment 619393 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditor.cpp
@@ +4592,5 @@
>                              bool aSafeToAskFrames)
>  {
> +  MOZ_ASSERT(aNode);
> +  MOZ_ASSERT(aNode->NodeType() == nsIDOMNode::TEXT_NODE);
> +  MOZ_ASSERT(outIsEmptyNode);

Nit: aNode && outIsEmptyNode
Attachment #619393 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4fb0fa799d9e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.