Last Comment Bug 750093 - Cleanup SetTextProperty in nsComposerCommands.cpp
: Cleanup SetTextProperty in nsComposerCommands.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-29 10:00 PDT by :Ms2ger
Modified: 2012-05-05 10:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.81 KB, patch)
2012-04-29 10:00 PDT, :Ms2ger
ehsan: review+
Details | Diff | Review

Description :Ms2ger 2012-04-29 10:00:52 PDT
Created attachment 619418 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari (out sick) 2012-04-30 10:43:16 PDT
Comment on attachment 619418 [details] [diff] [review]
Patch v1

Review of attachment 619418 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/src/nsComposerCommands.cpp
@@ +1594,4 @@
>  
>    /// XXX Hack alert! Look in nsIEditProperty.h for this
> +  nsCOMPtr<nsIAtom> styleAtom = do_GetAtom(aProp);
> +  NS_ENSURE_TRUE(styleAtom, NS_ERROR_OUT_OF_MEMORY);

do_GetAtom should never return null...  But I'm fine if you leave this check in either.
Comment 2 :Ms2ger 2012-04-30 11:32:54 PDT
Leaving it in for now.

Note You need to log in before you can comment on or make changes to this bug.