Cleanup SetTextProperty in nsComposerCommands.cpp

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 619418 [details] [diff] [review]
Patch v1
Attachment #619418 - Flags: review?(ehsan)
Comment on attachment 619418 [details] [diff] [review]
Patch v1

Review of attachment 619418 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/src/nsComposerCommands.cpp
@@ +1594,4 @@
>  
>    /// XXX Hack alert! Look in nsIEditProperty.h for this
> +  nsCOMPtr<nsIAtom> styleAtom = do_GetAtom(aProp);
> +  NS_ENSURE_TRUE(styleAtom, NS_ERROR_OUT_OF_MEMORY);

do_GetAtom should never return null...  But I'm fine if you leave this check in either.
Attachment #619418 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
Leaving it in for now.
Summary: Cleanup SetTextProperty in SetTextProperty → Cleanup SetTextProperty in nsComposerCommands.cpp
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/79e26f1d9adb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.