Closed
Bug 750093
Opened 13 years ago
Closed 13 years ago
Cleanup SetTextProperty in nsComposerCommands.cpp
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
2.81 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #619418 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 619418 [details] [diff] [review]
Patch v1
Review of attachment 619418 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/composer/src/nsComposerCommands.cpp
@@ +1594,4 @@
>
> /// XXX Hack alert! Look in nsIEditProperty.h for this
> + nsCOMPtr<nsIAtom> styleAtom = do_GetAtom(aProp);
> + NS_ENSURE_TRUE(styleAtom, NS_ERROR_OUT_OF_MEMORY);
do_GetAtom should never return null... But I'm fine if you leave this check in either.
Attachment #619418 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Leaving it in for now.
Summary: Cleanup SetTextProperty in SetTextProperty → Cleanup SetTextProperty in nsComposerCommands.cpp
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•