The default bug view has changed. See this FAQ.

Some cleanup in nsComposerCommands.cpp

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 619420 [details] [diff] [review]
Patch v1
Attachment #619420 - Flags: review?(ehsan)
Comment on attachment 619420 [details] [diff] [review]
Patch v1

Review of attachment 619420 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/src/nsComposerCommands.cpp
@@ +876,5 @@
> +  NS_ENSURE_SUCCESS(rv, rv);
> +
> +  nsCAutoString tOutStateString;
> +  tOutStateString.AssignWithConversion(outStateString);
> +  aParams->SetBooleanValue(STATE_MIXED,outMixed);

Nit: space after comma please.  :-)

@@ +1072,5 @@
>    nsCOMPtr<nsIDOMElement>  elt;
>    nsresult rv = htmlEditor->GetAbsolutelyPositionedSelectionContainer(getter_AddRefs(elt));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  return htmlEditor->AbsolutePositionSelection(!!elt);

IINM, you're reversing the boolean parameter here.
Attachment #619420 - Flags: review?(ehsan) → review-
(Assignee)

Comment 2

5 years ago
Created attachment 619623 [details] [diff] [review]
Patch v2

That's what you're for ;)
Attachment #619420 - Attachment is obsolete: true
Attachment #619623 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #619623 - Flags: review?(ehsan) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f5e54f531a4e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.