Closed Bug 750094 Opened 9 years ago Closed 9 years ago

Some cleanup in nsComposerCommands.cpp

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #619420 - Flags: review?(ehsan)
Comment on attachment 619420 [details] [diff] [review]
Patch v1

Review of attachment 619420 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/src/nsComposerCommands.cpp
@@ +876,5 @@
> +  NS_ENSURE_SUCCESS(rv, rv);
> +
> +  nsCAutoString tOutStateString;
> +  tOutStateString.AssignWithConversion(outStateString);
> +  aParams->SetBooleanValue(STATE_MIXED,outMixed);

Nit: space after comma please.  :-)

@@ +1072,5 @@
>    nsCOMPtr<nsIDOMElement>  elt;
>    nsresult rv = htmlEditor->GetAbsolutelyPositionedSelectionContainer(getter_AddRefs(elt));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  return htmlEditor->AbsolutePositionSelection(!!elt);

IINM, you're reversing the boolean parameter here.
Attachment #619420 - Flags: review?(ehsan) → review-
Attached patch Patch v2Splinter Review
That's what you're for ;)
Attachment #619420 - Attachment is obsolete: true
Attachment #619623 - Flags: review?(ehsan)
Attachment #619623 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/f5e54f531a4e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.