750094 - Some cleanup in nsComposerCommands.cpp

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[(no longer active)]

Comment on attachment 619420 [details] [diff] [review]
Patch v1

Review of attachment 619420 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/src/nsComposerCommands.cpp
@@ +876,5 @@
> +  NS_ENSURE_SUCCESS(rv, rv);
> +
> +  nsCAutoString tOutStateString;
> +  tOutStateString.AssignWithConversion(outStateString);
> +  aParams->SetBooleanValue(STATE_MIXED,outMixed);

Nit: space after comma please.  :-)

@@ +1072,5 @@
>    nsCOMPtr<nsIDOMElement>  elt;
>    nsresult rv = htmlEditor->GetAbsolutelyPositionedSelectionContainer(getter_AddRefs(elt));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  return htmlEditor->AbsolutePositionSelection(!!elt);

IINM, you're reversing the boolean parameter here.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

That's what you're for ;)

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f5e54f531a4e