Last Comment Bug 750094 - Some cleanup in nsComposerCommands.cpp
: Some cleanup in nsComposerCommands.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-29 10:05 PDT by :Ms2ger
Modified: 2012-05-05 10:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (10.64 KB, patch)
2012-04-29 10:05 PDT, :Ms2ger
ehsan: review-
Details | Diff | Splinter Review
Patch v2 (10.64 KB, patch)
2012-04-30 11:28 PDT, :Ms2ger
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger 2012-04-29 10:05:20 PDT
Created attachment 619420 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari 2012-04-30 10:40:10 PDT
Comment on attachment 619420 [details] [diff] [review]
Patch v1

Review of attachment 619420 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/src/nsComposerCommands.cpp
@@ +876,5 @@
> +  NS_ENSURE_SUCCESS(rv, rv);
> +
> +  nsCAutoString tOutStateString;
> +  tOutStateString.AssignWithConversion(outStateString);
> +  aParams->SetBooleanValue(STATE_MIXED,outMixed);

Nit: space after comma please.  :-)

@@ +1072,5 @@
>    nsCOMPtr<nsIDOMElement>  elt;
>    nsresult rv = htmlEditor->GetAbsolutelyPositionedSelectionContainer(getter_AddRefs(elt));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  return htmlEditor->AbsolutePositionSelection(!!elt);

IINM, you're reversing the boolean parameter here.
Comment 2 :Ms2ger 2012-04-30 11:28:34 PDT
Created attachment 619623 [details] [diff] [review]
Patch v2

That's what you're for ;)

Note You need to log in before you can comment on or make changes to this bug.