Closed
Bug 750094
Opened 13 years ago
Closed 13 years ago
Some cleanup in nsComposerCommands.cpp
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file, 1 obsolete file)
|
10.64 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #619420 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 619420 [details] [diff] [review]
Patch v1
Review of attachment 619420 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/composer/src/nsComposerCommands.cpp
@@ +876,5 @@
> + NS_ENSURE_SUCCESS(rv, rv);
> +
> + nsCAutoString tOutStateString;
> + tOutStateString.AssignWithConversion(outStateString);
> + aParams->SetBooleanValue(STATE_MIXED,outMixed);
Nit: space after comma please. :-)
@@ +1072,5 @@
> nsCOMPtr<nsIDOMElement> elt;
> nsresult rv = htmlEditor->GetAbsolutelyPositionedSelectionContainer(getter_AddRefs(elt));
> NS_ENSURE_SUCCESS(rv, rv);
>
> + return htmlEditor->AbsolutePositionSelection(!!elt);
IINM, you're reversing the boolean parameter here.
Attachment #619420 -
Flags: review?(ehsan) → review-
|
Assignee | |
Comment 2•13 years ago
|
||
That's what you're for ;)
Attachment #619420 -
Attachment is obsolete: true
Attachment #619623 -
Flags: review?(ehsan)
|
|
||
Updated•13 years ago
|
Attachment #619623 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•