Last Comment Bug 750191 - move IsTextInterfaceSupportCorrect under DEBUG ifdef
: move IsTextInterfaceSupportCorrect under DEBUG ifdef
Status: RESOLVED FIXED
[good first bug][mentor=hub@mozilla.c...
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mark Capella [:capella]
:
Mentors:
Depends on:
Blocks: cleana11y
  Show dependency treegraph
 
Reported: 2012-04-30 02:32 PDT by alexander :surkov
Modified: 2012-05-08 03:22 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (3.69 KB, patch)
2012-05-05 14:22 PDT, Mark Capella [:capella]
hub: feedback+
Details | Diff | Review
Patch (v2) (4.94 KB, patch)
2012-05-07 01:05 PDT, Mark Capella [:capella]
surkov.alexander: review+
Details | Diff | Review

Description alexander :surkov 2012-04-30 02:32:55 PDT
IsTextInterfaceSupportCorrect is under DEBUG_A11Y, move all related pieces to DEBUG ifdef.
Comment 1 Mark Capella [:capella] 2012-05-05 14:22:29 PDT
Created attachment 621343 [details] [diff] [review]
Patch (v1)

Small technical change patch....
Comment 2 Hubert Figuiere [:hub] 2012-05-06 23:49:01 PDT
Comment on attachment 621343 [details] [diff] [review]
Patch (v1)

looks good.

but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp
Comment 3 Mark Capella [:capella] 2012-05-07 01:05:26 PDT
Created attachment 621529 [details] [diff] [review]
Patch (v2)

Thanks! Not sure how I missed that during my scan ...

New patch, builds and mochitests ok locally ...
Comment 4 alexander :surkov 2012-05-07 03:21:15 PDT
(In reply to Hub Figuiere [:hub] from comment #2)

> but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp

I wasn't sure about this one (not it's not covered by bug summary) but if you want to take it in then it's fine with me I think.
Comment 5 alexander :surkov 2012-05-07 04:16:55 PDT
Mark, it'd be great if you start try server build before asking for review to make sure you don't have compilation errors (in case if you don't do that). This one produces errors https://tbpl.mozilla.org/php/getParsedLog.php?id=11528704&tree=Try&full=1#error0. I'll fix them before landing.
Comment 7 Ed Morley [:emorley] 2012-05-08 03:22:06 PDT
https://hg.mozilla.org/mozilla-central/rev/9b7bea577a43

Note You need to log in before you can comment on or make changes to this bug.