Closed Bug 750191 Opened 8 years ago Closed 8 years ago

move IsTextInterfaceSupportCorrect under DEBUG ifdef

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: surkov, Assigned: capella)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])

Attachments

(1 file, 1 obsolete file)

IsTextInterfaceSupportCorrect is under DEBUG_A11Y, move all related pieces to DEBUG ifdef.
Attached patch Patch (v1) (obsolete) — Splinter Review
Small technical change patch....
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #621343 - Flags: feedback?(hub)
Comment on attachment 621343 [details] [diff] [review]
Patch (v1)

looks good.

but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp
Attachment #621343 - Flags: feedback?(hub) → feedback+
Attached patch Patch (v2)Splinter Review
Thanks! Not sure how I missed that during my scan ...

New patch, builds and mochitests ok locally ...
Attachment #621343 - Attachment is obsolete: true
Attachment #621529 - Flags: review?(surkov.alexander)
(In reply to Hub Figuiere [:hub] from comment #2)

> but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp

I wasn't sure about this one (not it's not covered by bug summary) but if you want to take it in then it's fine with me I think.
Attachment #621529 - Flags: review?(surkov.alexander) → review+
Mark, it'd be great if you start try server build before asking for review to make sure you don't have compilation errors (in case if you don't do that). This one produces errors https://tbpl.mozilla.org/php/getParsedLog.php?id=11528704&tree=Try&full=1#error0. I'll fix them before landing.
https://hg.mozilla.org/mozilla-central/rev/9b7bea577a43
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.