Closed Bug 750191 Opened 8 years ago Closed 8 years ago
Text Interface Support Correct under DEBUG ifdef
IsTextInterfaceSupportCorrect is under DEBUG_A11Y, move all related pieces to DEBUG ifdef.
Small technical change patch....
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #621343 - Flags: feedback?(hub)
Comment on attachment 621343 [details] [diff] [review] Patch (v1) looks good. but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp
Attachment #621343 - Flags: feedback?(hub) → feedback+
Thanks! Not sure how I missed that during my scan ... New patch, builds and mochitests ok locally ...
Attachment #621343 - Attachment is obsolete: true
Attachment #621529 - Flags: review?(surkov.alexander)
(In reply to Hub Figuiere [:hub] from comment #2) > but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp I wasn't sure about this one (not it's not covered by bug summary) but if you want to take it in then it's fine with me I think.
Attachment #621529 - Flags: review?(surkov.alexander) → review+
Mark, it'd be great if you start try server build before asking for review to make sure you don't have compilation errors (in case if you don't do that). This one produces errors https://tbpl.mozilla.org/php/getParsedLog.php?id=11528704&tree=Try&full=1#error0. I'll fix them before landing.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.