The default bug view has changed. See this FAQ.

move IsTextInterfaceSupportCorrect under DEBUG ifdef

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
IsTextInterfaceSupportCorrect is under DEBUG_A11Y, move all related pieces to DEBUG ifdef.
(Assignee)

Comment 1

5 years ago
Created attachment 621343 [details] [diff] [review]
Patch (v1)

Small technical change patch....
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #621343 - Flags: feedback?(hub)
Comment on attachment 621343 [details] [diff] [review]
Patch (v1)

looks good.

but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp
Attachment #621343 - Flags: feedback?(hub) → feedback+
(Assignee)

Comment 3

5 years ago
Created attachment 621529 [details] [diff] [review]
Patch (v2)

Thanks! Not sure how I missed that during my scan ...

New patch, builds and mochitests ok locally ...
Attachment #621343 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #621529 - Flags: review?(surkov.alexander)
(Reporter)

Comment 4

5 years ago
(In reply to Hub Figuiere [:hub] from comment #2)

> but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp

I wasn't sure about this one (not it's not covered by bug summary) but if you want to take it in then it's fine with me I think.
(Reporter)

Updated

5 years ago
Attachment #621529 - Flags: review?(surkov.alexander) → review+
(Reporter)

Comment 5

5 years ago
Mark, it'd be great if you start try server build before asking for review to make sure you don't have compilation errors (in case if you don't do that). This one produces errors https://tbpl.mozilla.org/php/getParsedLog.php?id=11528704&tree=Try&full=1#error0. I'll fix them before landing.
(Reporter)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7bea577a43
https://hg.mozilla.org/mozilla-central/rev/9b7bea577a43
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.