750283 - notify observers of a11y init / shutdown in nsAccessibilityService

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

move the call to NotifyObservers() to nsAccessibilityService.cpp (Init() and Shutdown()) from nsAccessNode.cpp InitXPAccessibility / ShutdownXPAccessibility().  both of those functions already have a ref to the observer service, so you can just call NotifyObservers() directly instead of through nsAccessNode::NotifyA11yInitOrShutdown().

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Quick patch ... builds and tests ok ...

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 620468 [details] [diff] [review]
Patch (v1)

/nsAccessNode.cpp
>--- a/accessible/src/base/nsAccessNode.cpp
>+++ b/accessible/src/base/nsAccessNode.cpp
>@@ -166,33 +166,16 @@ void nsAccessNode::InitXPAccessibility()

this file no longer uses nsIObserverService so remove that header from being included

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 620468 [details] [diff] [review]
Patch (v1)

Review of attachment 620468 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessibilityService.cpp
@@ +1290,1 @@
>      observerService->RemoveObserver(this, NS_XPCOM_SHUTDOWN_OBSERVER_ID);

perhaps i'd have empty lines between these

Comment 4

[Mark Capella [:capella]]

Attachment: Patch (v2) Nits Addressed

Comment 5

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86f237e55dd9

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/86f237e55dd9