Last Comment Bug 750283 - notify observers of a11y init / shutdown in nsAccessibilityService
: notify observers of a11y init / shutdown in nsAccessibilityService
Status: RESOLVED FIXED
[good first bug][mentor=trev.saunders...
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mark Capella [:capella]
:
Mentors:
Depends on:
Blocks: cleana11y 750287
  Show dependency treegraph
 
Reported: 2012-04-30 08:29 PDT by Trevor Saunders (:tbsaunde)
Modified: 2012-05-07 16:14 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (4.40 KB, patch)
2012-05-02 14:23 PDT, Mark Capella [:capella]
tbsaunde+mozbugs: review+
surkov.alexander: feedback+
Details | Diff | Review
Patch (v2) Nits Addressed (4.89 KB, patch)
2012-05-03 06:05 PDT, Mark Capella [:capella]
no flags Details | Diff | Review

Description Trevor Saunders (:tbsaunde) 2012-04-30 08:29:24 PDT
move the call to NotifyObservers() to nsAccessibilityService.cpp (Init() and Shutdown()) from nsAccessNode.cpp InitXPAccessibility / ShutdownXPAccessibility().  both of those functions already have a ref to the observer service, so you can just call NotifyObservers() directly instead of through nsAccessNode::NotifyA11yInitOrShutdown().
Comment 1 Mark Capella [:capella] 2012-05-02 14:23:50 PDT
Created attachment 620468 [details] [diff] [review]
Patch (v1)

Quick patch ... builds and tests ok ...
Comment 2 Trevor Saunders (:tbsaunde) 2012-05-03 04:03:52 PDT
Comment on attachment 620468 [details] [diff] [review]
Patch (v1)

/nsAccessNode.cpp
>--- a/accessible/src/base/nsAccessNode.cpp
>+++ b/accessible/src/base/nsAccessNode.cpp
>@@ -166,33 +166,16 @@ void nsAccessNode::InitXPAccessibility()

this file no longer uses nsIObserverService so remove that header from being included
Comment 3 alexander :surkov 2012-05-03 04:51:44 PDT
Comment on attachment 620468 [details] [diff] [review]
Patch (v1)

Review of attachment 620468 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessibilityService.cpp
@@ +1290,1 @@
>      observerService->RemoveObserver(this, NS_XPCOM_SHUTDOWN_OBSERVER_ID);

perhaps i'd have empty lines between these
Comment 4 Mark Capella [:capella] 2012-05-03 06:05:09 PDT
Created attachment 620670 [details] [diff] [review]
Patch (v2) Nits Addressed
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2012-05-07 16:14:09 PDT
https://hg.mozilla.org/mozilla-central/rev/86f237e55dd9

Note You need to log in before you can comment on or make changes to this bug.