The default bug view has changed. See this FAQ.

notify observers of a11y init / shutdown in nsAccessibilityService

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tbsaunde, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
move the call to NotifyObservers() to nsAccessibilityService.cpp (Init() and Shutdown()) from nsAccessNode.cpp InitXPAccessibility / ShutdownXPAccessibility().  both of those functions already have a ref to the observer service, so you can just call NotifyObservers() directly instead of through nsAccessNode::NotifyA11yInitOrShutdown().
(Assignee)

Comment 1

5 years ago
Created attachment 620468 [details] [diff] [review]
Patch (v1)

Quick patch ... builds and tests ok ...
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #620468 - Flags: review?(trev.saunders)
(Reporter)

Comment 2

5 years ago
Comment on attachment 620468 [details] [diff] [review]
Patch (v1)

/nsAccessNode.cpp
>--- a/accessible/src/base/nsAccessNode.cpp
>+++ b/accessible/src/base/nsAccessNode.cpp
>@@ -166,33 +166,16 @@ void nsAccessNode::InitXPAccessibility()

this file no longer uses nsIObserverService so remove that header from being included
Attachment #620468 - Flags: review?(trev.saunders)
Attachment #620468 - Flags: review+
Attachment #620468 - Flags: feedback?(surkov.alexander)

Comment 3

5 years ago
Comment on attachment 620468 [details] [diff] [review]
Patch (v1)

Review of attachment 620468 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessibilityService.cpp
@@ +1290,1 @@
>      observerService->RemoveObserver(this, NS_XPCOM_SHUTDOWN_OBSERVER_ID);

perhaps i'd have empty lines between these
Attachment #620468 - Flags: feedback?(surkov.alexander) → feedback+
(Assignee)

Updated

5 years ago
Blocks: 750287
(Assignee)

Comment 4

5 years ago
Created attachment 620670 [details] [diff] [review]
Patch (v2) Nits Addressed

Updated

5 years ago
Attachment #620468 - Attachment is obsolete: true

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/86f237e55dd9
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/86f237e55dd9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.