750307 - "Assertion failure: isBoolean(),"

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

Math.tan(
    Object.defineProperty(
        evalcx("new RegExp"),
        "ignoreCase",
        {e:true}
    )
)

asserts js debug shell on m-c changeset cfaf90b22fc3 without any CLI arguments at Assertion failure: isBoolean(),

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   78732:61dd23c012ee
user:        Chris Leary
date:        Fri Oct 07 03:04:00 2011 -0700
summary:     Bug 673188: Compile regexps lazily. (r=mrbkap)

Comment 1

[Jason Orendorff [:jorendorff]]

Hmm. Having a little trouble tracking this one down actually. Taking.

Comment 2

[Jason Orendorff [:jorendorff]]

This should have been obvious to me at the outset. Not sure what I was thinking.

1. For cross-compartment wrappers, Object.defineProperty ultimately calls JS_DefinePropertyById.

2. JS_DefinePropertyById allows the redefinition of non-writable non-configurable properties, contrary to ES5. In particular it does not do all the checking that obj_DefineProperty does when the target object is native.

3. RegExpObject::toString assumes the values of the "ignoreCase" non-writable non-configurable property can't be changed.

Comment 3

[Jason Orendorff [:jorendorff]]

To break it down a little bit:

let a = evalcx("/x/");   // make a cross-compartment wrapper around a RegExp object
Object.defineProperty(a, "ignoreCase", {value: undefined});  // see comment 2
a.toString();  // trip an assertion that ignoreCase has a boolean value

Comment 4

[Jason Orendorff [:jorendorff]]

My first attempt was to make JS_Define* respect the invariants.
This was doomed because the JS_Define* functions are the APIs resolve hooks are supposed to use. We'd get call stacks like:

   some kind of lookup
   -> resolve hook
   -> JS_DefineProperty
   -> do a lookup to check the invariants
   -> resolve hook
      ...

The resolve machinery has some goofy hash table to prevent runaway recursion in this case, but it still causes problems. I think causing JS_Define* to do lookups is too much of an API change for Aurora.

A more modest change is to change wrappers so that instead of using JS_DefinePropertyById directly, they enforce the invariants. Pursuing that now.

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 630656 [details] [diff] [review]
v1

Review of attachment 630656 [details] [diff] [review]:
-----------------------------------------------------------------

The property definition algorithms are complicated enough that I'm not especially confident I haven't missed anything here, but I think you might have covered the bases.

::: js/src/jit-test/tests/basic/bug750307.js
@@ +1,5 @@
> +var g = newGlobal('new-compartment');
> +var a = g.RegExp("x");
> +try {
> +    Object.defineProperty(a, "ignoreCase", {value: undefined});
> +} catch (exc) {}

assertEq(exc instanceof g.TypeError, true); // it's g.TypeError and not TypeError, right?  And an assert verifying that an error was actually thrown, too.

Comment 7

[Jason Orendorff [:jorendorff]]

Good idea.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7166a68a7994

Comment 8

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/65c7255e9d15 for the "browser_bug645699.js | an unexpected uncaught JS exception reported through window.onerror - TypeError: can't redefine non-configurable property 'location' at http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/bug645699.html:12" etc. in https://tbpl.mozilla.org/php/getParsedLog.php?id=12567825&tree=Mozilla-Inbound and friends.

Comment 9

[Jason Orendorff [:jorendorff]]

Thanks for the backout. Looks like we should just change the test, though. I'll push to try in a minute.

Comment 10

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=d87a33f7beb0

Comment 11

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Jason Orendorff [:jorendorff] from comment #10)
> https://tbpl.mozilla.org/?tree=Try&rev=d87a33f7beb0

Try looks green - should be good to land! \o/

Comment 12

[Phil Ringnalda (:philor)]

That must have been intended for some other bug, since every mochitest-oth which has run has a failure in the same test (plus, what's pushed to try isn't even in this bug, so checkin-needed would just reland the same thing that already bounced).

Comment 13

[Jason Orendorff [:jorendorff]]

It was just a botch. Here's the fixed try run.
https://tbpl.mozilla.org/?tree=Try&rev=07957da489ad

Comment 14

[Jason Orendorff [:jorendorff]]

Attachment: v2 - same as v1, but fix a test

Carrying forward review.

Comment 15

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ddb6278d1de

Comment 16

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/2ddb6278d1de

Comment 17

[Scoobidiver (away)]

It seems it landed in 15.a2/20120629:
http://hg.mozilla.org/releases/mozilla-aurora/rev/2f5ede40b4f5

Comment 18

[Ed Morley [:emorley]]

Landed on beta as:
https://hg.mozilla.org/releases/mozilla-beta/rev/acb98d65fa59
(Bug doesn't seem to have been updated to reflect that)

However backed out of beta for M3 orange:
https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=acb98d65fa59

https://hg.mozilla.org/releases/mozilla-beta/rev/61b48c85c866

Comment 20

[Mihaela Velimiroviciu (:mihaelav)]

I built Spidermonkey for the latest Firefox 15 version (beta5, Changeset	5b309ad1a88a) and run the test from comment #0. The reported assertion did not show, but instead I got the following assertion:
test750307:5: TypeError: "ignoreCase" is read-only

Is this expected?

Thank you!

Comment 21

[u279076]

Confirmed testcase asserts 2012-04-30 mozilla-central debug JS shell.

Does not assert:
2012-06-14 mozilla-central debug JS shell
2012-07-01 mozilla-aurora debug JS shell

Comment 22

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/releases/mozilla-esr10/rev/6b471843f125

Approval granted separately in bug 756719.

Comment 23

[Justin Wood (:Callek)]

(In reply to Jason Orendorff [:jorendorff] from comment #22)
> https://hg.mozilla.org/releases/mozilla-esr10/rev/6b471843f125
> 
> Approval granted separately in bug 756719.

Had oranges in mochi-4 and mochi-oth across all platforms, backed out
https://hg.mozilla.org/releases/mozilla-esr10/rev/e78926e3cef0

Comment 24

[Jason Orendorff [:jorendorff]]

Re-landed:

   https://hg.mozilla.org/releases/mozilla-esr10/rev/9708ce55a237
   https://hg.mozilla.org/releases/mozilla-esr10/rev/b3600020156d

The "part 2" patch got review and approval separately, in bug 756719.

There's no way to get a Try Server run on ESR10 at present, so I'm not as confident in these patches as I'd normally like to be, but at worst, we back them out again...

Comment 25

[Andrew McCreight [:mccr8]]

> but at worst, we back them out again...
At worst it is!  Backed out for Moth oranges.

https://hg.mozilla.org/releases/mozilla-esr10/rev/96931ca23431

Comment 26

[Andrew McCreight [:mccr8]]

I managed to only back out the second part, so here's another attempt to finish the job.

https://hg.mozilla.org/releases/mozilla-esr10/rev/d449bf8cd785

Comment 27

[David Mandelin [:dmandelin]]

Attachment: ESR attempt -- undoes part of the ESR extra bit

Moth seems to fail more with the extra ESR fix on than not, so this this is a more minimal version of the ESR fix. It's impossible to quickly figure out what's really going wrong or what's needed, but this may work. Currently running on try. I'll check again in the morning.

Comment 28

[Andrew McCreight [:mccr8]]

You can't use Try for ESR-10 (it won't build), which is kind of the root of this whole problem. You'll have to run Moth locally.

Comment 29

[David Mandelin [:dmandelin]]

(In reply to Andrew McCreight [:mccr8] from comment #28)
> You can't use Try for ESR-10 (it won't build), which is kind of the root of
> this whole problem. You'll have to run Moth locally.

That is super lame. Hopefully Jason can pick it up in the morning then.

Comment 30

[Jason Orendorff [:jorendorff]]

I'm working on this now.

Comment 31

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/releases/mozilla-esr10/rev/f19e6807b8bb
https://hg.mozilla.org/releases/mozilla-esr10/rev/89d8746d16c5