Closed Bug 750370 Opened 8 years ago Closed 8 years ago

GCC 4.6.3 build warning: nsDocument.cpp:6636:51: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Filing bug on these build warnings:

../../../../mozilla/content/base/src/nsDocument.cpp: In member function ‘virtual nsresult nsDocument::RemoveFromRadioGroup(const nsAString_internal&, nsIFormControl*)’:
../../../../mozilla/content/base/src/nsDocument.cpp:6636:51: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
../../../../mozilla/content/base/src/nsDocument.cpp: In member function ‘virtual void nsDocument::RadioRequiredChanged(const nsAString_internal&, nsIFormControl*)’:
../../../../mozilla/content/base/src/nsDocument.cpp:6689:51: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

These warnings are about assertions that nsRadioGroupStruct::mRequiredRadioCount is >=0 -- that variable was actually unsigned when it was added...
   http://hg.mozilla.org/mozilla-central/rev/10fe279c3613#l1.21
...so these assertions have always been no-ops.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #619622 - Flags: review?(mounir)
Attachment #619622 - Flags: review?(mounir) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/273e1b850db8
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/273e1b850db8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.