Last Comment Bug 750370 - GCC 4.6.3 build warning: nsDocument.cpp:6636:51: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
: GCC 4.6.3 build warning: nsDocument.cpp:6636:51: warning: comparison of unsig...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Daniel Holbert [:dholbert]
:
:
Mentors:
Depends on:
Blocks: buildwarning 635008
  Show dependency treegraph
 
Reported: 2012-04-30 11:21 PDT by Daniel Holbert [:dholbert]
Modified: 2012-05-04 11:41 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (2.05 KB, patch)
2012-04-30 11:26 PDT, Daniel Holbert [:dholbert]
mounir: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2012-04-30 11:21:46 PDT
Filing bug on these build warnings:

../../../../mozilla/content/base/src/nsDocument.cpp: In member function ‘virtual nsresult nsDocument::RemoveFromRadioGroup(const nsAString_internal&, nsIFormControl*)’:
../../../../mozilla/content/base/src/nsDocument.cpp:6636:51: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
../../../../mozilla/content/base/src/nsDocument.cpp: In member function ‘virtual void nsDocument::RadioRequiredChanged(const nsAString_internal&, nsIFormControl*)’:
../../../../mozilla/content/base/src/nsDocument.cpp:6689:51: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

These warnings are about assertions that nsRadioGroupStruct::mRequiredRadioCount is >=0 -- that variable was actually unsigned when it was added...
   http://hg.mozilla.org/mozilla-central/rev/10fe279c3613#l1.21
...so these assertions have always been no-ops.
Comment 1 Daniel Holbert [:dholbert] 2012-04-30 11:26:39 PDT
Created attachment 619622 [details] [diff] [review]
fix
Comment 2 Daniel Holbert [:dholbert] 2012-05-03 18:56:06 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/273e1b850db8
Comment 3 Ed Morley [:emorley] 2012-05-04 11:41:59 PDT
https://hg.mozilla.org/mozilla-central/rev/273e1b850db8

Note You need to log in before you can comment on or make changes to this bug.