750445 - Fix for bug 235853 landed broken: unused variable in LookupProxyInfo.

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jason Duell]

Attachment: v1

Yay for WARNINGS_AS_ERRORS.  It just turned up that we're not actually using the 'flags' variable we set in LookupProxyInfo().  
 
This code was recently refactored by Patrick (bug 723628), but the actual bug has been sitting there since bug 235853:

  http://hg.mozilla.org/mozilla-central/diff/20240add1d35/netwerk/base/src/nsIOService.cpp

We set flags=RESOLVE_NON_BLOCKING but don't use it.  This appears to be a result of jdm's rebase here:

  https://bugzilla.mozilla.org/attachment.cgi?id=594181&action=diff

The original patch from jrmuizel used the flags variable, but ignored the aProxyFlags parameter.  But that seems wrong to me too:

   https://bugzilla.mozilla.org/attachment.cgi?id=346370&action=diff

Seems like we should be adding the non-blocking flag to the passed-in flags.  Otherwise we are basically dropping the passed-in flags on the floor. (We only have one C++ client--websockets--that calls this with flags: I suspect this may be causing bug 713026)

I assume this means that we're still blocking the main thread for PAC DNS resolution? Did we ever actually test that? :(

Comment 1

[Jason Duell]

Correction: we're using the passed-in flags now, so this isn't causing bug 713026.  But it we start ignoring them, it will make that bug more broken :)

Comment 2

[Jason Duell]

Comment on attachment 619662 [details] [diff] [review]
v1

clearing review--this little patch somehow messes up most tests in test_websocket.html.

Comment 3

[gak]

Is there any update on this?  Can it please get fixed soon?

Comment 4

[Jason Duell]

Yes, we've had a recent eruption of proxy-related bugs which we are plowing through, and this is on that list.

Comment 5

[gak]

thank you for the update Jason.  is there a target release or timeframe?

Comment 6

[Patrick McManus [:mcmanus]]

Comment on attachment 619662 [details] [diff] [review]
v1

Review of attachment 619662 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/src/nsIOService.cpp
@@ +630,1 @@
>          rv = mProxyService->Resolve(aProxyURI ? aProxyURI : aURI, aProxyFlags,

hopefully this should just be aProxyFlags |= nsIProtocolProxyService::RESOLVE_NON_BLOCKING;

I'll retest websockets mochi with that.

Comment 7

[Patrick McManus [:mcmanus]]

The unused variable basis of this bug report will be cured by the backout that will be done by 767005.

The portions of this bug report that deal with removing blocking from PAC file usage will be undertaken in bug 769764.

Comment 8

[Patrick McManus [:mcmanus]]

fixed by 767005

Comment 9

[Ioana (away)]

Patrick, is there anything QA can do to verify this fix?