Fix for bug 235853 landed broken: unused variable in LookupProxyInfo.

RESOLVED FIXED in Firefox 15

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jduell, Assigned: mcmanus)

Tracking

unspecified
mozilla17
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox15 fixed, firefox16 fixed)

Details

Attachments

(1 attachment)

Created attachment 619662 [details] [diff] [review]
v1

Yay for WARNINGS_AS_ERRORS.  It just turned up that we're not actually using the 'flags' variable we set in LookupProxyInfo().  
 
This code was recently refactored by Patrick (bug 723628), but the actual bug has been sitting there since bug 235853:

  http://hg.mozilla.org/mozilla-central/diff/20240add1d35/netwerk/base/src/nsIOService.cpp

We set flags=RESOLVE_NON_BLOCKING but don't use it.  This appears to be a result of jdm's rebase here:

  https://bugzilla.mozilla.org/attachment.cgi?id=594181&action=diff

The original patch from jrmuizel used the flags variable, but ignored the aProxyFlags parameter.  But that seems wrong to me too:

   https://bugzilla.mozilla.org/attachment.cgi?id=346370&action=diff

Seems like we should be adding the non-blocking flag to the passed-in flags.  Otherwise we are basically dropping the passed-in flags on the floor. (We only have one C++ client--websockets--that calls this with flags: I suspect this may be causing bug 713026)

I assume this means that we're still blocking the main thread for PAC DNS resolution? Did we ever actually test that? :(
Attachment #619662 - Flags: review?(cbiesinger)
Attachment #619662 - Flags: feedback?(jmuizelaar)
(Reporter)

Comment 1

5 years ago
Correction: we're using the passed-in flags now, so this isn't causing bug 713026.  But it we start ignoring them, it will make that bug more broken :)
(Reporter)

Updated

5 years ago
Blocks: 745296
No longer blocks: 557566
(Reporter)

Comment 2

5 years ago
Comment on attachment 619662 [details] [diff] [review]
v1

clearing review--this little patch somehow messes up most tests in test_websocket.html.
Attachment #619662 - Flags: review?(cbiesinger)
Attachment #619662 - Flags: feedback?(jmuizelaar)

Comment 3

5 years ago
Is there any update on this?  Can it please get fixed soon?
(Reporter)

Comment 4

5 years ago
Yes, we've had a recent eruption of proxy-related bugs which we are plowing through, and this is on that list.

Comment 5

5 years ago
thank you for the update Jason.  is there a target release or timeframe?
(Assignee)

Updated

5 years ago
Assignee: jduell.mcbugs → mcmanus
(Assignee)

Comment 6

5 years ago
Comment on attachment 619662 [details] [diff] [review]
v1

Review of attachment 619662 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/src/nsIOService.cpp
@@ +630,1 @@
>          rv = mProxyService->Resolve(aProxyURI ? aProxyURI : aURI, aProxyFlags,

hopefully this should just be aProxyFlags |= nsIProtocolProxyService::RESOLVE_NON_BLOCKING;

I'll retest websockets mochi with that.
(Assignee)

Updated

5 years ago
Blocks: 769764
(Assignee)

Comment 7

5 years ago
The unused variable basis of this bug report will be cured by the backout that will be done by 767005.

The portions of this bug report that deal with removing blocking from PAC file usage will be undertaken in bug 769764.
(Assignee)

Comment 8

5 years ago
fixed by 767005
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
status-firefox15: --- → fixed
status-firefox16: --- → fixed
Depends on: 767005
Target Milestone: --- → mozilla17

Comment 9

5 years ago
Patrick, is there anything QA can do to verify this fix?
You need to log in before you can comment on or make changes to this bug.