Last Comment Bug 750547 - Remove a dead branch from js_AtomizeString
: Remove a dead branch from js_AtomizeString
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Terrence Cole [:terrence]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-30 16:23 PDT by Terrence Cole [:terrence]
Modified: 2012-05-05 03:37 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
v0: trivial fix (976 bytes, patch)
2012-04-30 16:23 PDT, Terrence Cole [:terrence] 		jwalden+bmo: review+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Terrence Cole [:terrence] 2012-04-30 16:23:02 PDT 
Created attachment 619746 [details] [diff] [review]
v0: trivial fix

A handful of edits over the past year have made this branch useless.
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2012-05-02 15:13:18 PDT 
Comment on attachment 619746 [details] [diff] [review]
v0: trivial fix

Review of attachment 619746 [details] [diff] [review]:
-----------------------------------------------------------------

You sure we shouldn't guard against cosmic rays flipping a bit and making that condition true?
Comment 2 Terrence Cole [:terrence] 2012-05-04 14:37:31 PDT 
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3238e70fcb2
Comment 3 Ed Morley [:emorley] 2012-05-05 03:37:15 PDT 
https://hg.mozilla.org/mozilla-central/rev/b3238e70fcb2
Note You need to log in before you can comment on or make changes to this bug.