750574 - [10.8] Build fails with "arch: posix_spawnp: egrep: Bad CPU type in executable"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

At least as of 10.8 DP3, it would appear that maybe Apple is no longer shipping universal binaries for (at least) egrep, so the fix we made to build on Lion (bug 655339) is no longer a valid option.

I just successfully built with FIXED_EGREP just pointing to egrep so perhaps we should go back to that.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Why is this confidential?

Comment 2

[(not currently active) Ted Mielczarek]

I'm going to assume "accidentally".

Steven: is that grep workaround still necessary on current Lion? Could we simply remove it entirely?

Comment 3

[Steven Michaud [:smichaud] (Retired)]

> Steven: is that grep workaround still necessary on current Lion?

Yes :-(

I just did a test build on OS X 10.7.3, with FIXED_EGREP pointing to egrep.

I suspect Apple will never fix bug 655339 on Lion (that they somehow consider that too big a change for a minor update).

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I marked it confidential because I wasn't really sure where the line is for non-public information about 10.8. I figured it was better to start overly cautious.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #4)

My understanding is that we're free to discuss Apple's pre-release builds to the extent that they directly effects us (e.g. bugs that we'd need to work around; new features that we'd need to support).

I got this from Josh, and have followed it since I started working on Mozilla.

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

This is working on MoLo but not sure if it'll break anything else. I think this will only hit Lion and then for older versions we'll just use egrep as it was. That should be ok if only Lion AKA darwin 11 was broken (sounds like the case).

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 623867 [details] [diff] [review]
Patch v0.1

Review of attachment 623867 [details] [diff] [review]:
-----------------------------------------------------------------

That should be fine.

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 623867 [details] [diff] [review]
Patch v0.1

I pushed to try (https://tbpl.mozilla.org/?tree=Try&rev=2d3af9fda07e) and it looks fine, so let's make this official.

Comment 9

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0c0d4a72648

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a0c0d4a72648