750734 - Virtual keyboard doesn't appear when opening Fennec with an url from an external application

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Martijn Wargers (dead)]

Steps to reproduce:
- Open a mail client (in my case gmail)
- Tap on one of the bugzilla mails with the bugzilla url on it
- Choose Nightly as the application which you want to open the url with
- Tap on one of the input boxes in the bug

Expected result:
- Input gets focus, virtual keyboard appears

Actual result:
- Input gets focus, but virtual keyboard doesnt appear.

Tested on the Samsung Galaxy Nexus, Android 4.0.4.

I see this bug also on Aurora, I don't see it in XUL Fennec.

Comment 1

[Aaron Train [:aaronmt]]

I can reproduce this, same use case same phone.

Comment 2

[Aaron Train [:aaronmt]]

Can reproduce this on any site, ie., Twitter/Facebook

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Brian - Can you dig into this and see if there is something in front-end causing it? Might be IME.

Comment 4

[Brian Nicholson (:bnicholson)]

Looks like an IME bug. We're calling showSoftInput() as expected, but it doesn't seem to be working. Here's a log: http://pastebin.mozilla.org/1611029

Here's the STR that I'm using:
1) From the AwesomeScreen, long tap http://bugzilla.mozilla.org and add it as a home screen shortcut.
2) Quit Fennec (menu > Quit).
3) Click the home screen shortcut.

This appears to only happen at startup for me. If, in step 2, I simply press home to minimize Fennec instead of quit, the keyboard shows up fine.

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: patch

According to the Android docs (http://developer.android.com/reference/android/view/inputmethod/InputMethodManager.html#showSoftInput%28android.view.View,%20int%29), the view parameter of showSoftInput() is "the currently focused view". I added a check to see whether the view is focused when this bug occurs, and it is not.

This patch ensures that the view is focused when the virtual keyboard is being shown.

Comment 6

[Brian Nicholson (:bnicholson)]

Attachment: patch 1.1

Removed some leftover logging

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 620152 [details] [diff] [review]
patch 1.1

LGTM!

Comment 8

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/mozilla-central/rev/e3a1a5c1aaa4

Comment 9

[Brian Nicholson (:bnicholson)]

Comment on attachment 620152 [details] [diff] [review]
patch 1.1

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: keyboard won't appear when launching fennec from external apps
Testing completed (on m-c, etc.): just landed on m-c
Risk to taking this patch (and alternatives if risky): low risk
String changes made by this patch: none

Comment 10

[Martijn Wargers (dead)]

Verified fixed in today's trunk build on the HTC Desire HD.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 620152 [details] [diff] [review]
patch 1.1

[Triage Comment]
Blocker for Fennec 1.0 Beta - approved for Aurora 14.

Comment 12

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/67ef9bc234fd