Closed
Bug 750817
Opened 13 years ago
Closed 13 years ago
Some xpcshell tests in netwerk/unit rely on Xpcomlib property and fail on Android
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file, 2 obsolete files)
4.26 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
Some xpcshell tests in netwerk/unit reference the 'Xpcomlib' property simply to find a data file that can be used for the test. On Android, libraries are packaged in the APK, so these tests fail when the library file cannot be opened. Using a known data file, included in the xpcshell test directories, should be equally effective and will work even in environments that don't have 'Xpcomlib'. (netwerk/test/unit/test_readline.js uses this method) The tests that currently reference 'Xpcomlib' are: netwerk/test/unit/test_file_protocol.js netwerk/test/unit/test_localstreams.js netwerk/test/unit/test_post.js
Assignee | ||
Comment 1•13 years ago
|
||
Instead of using 'Xpcomlib' to find a file, use test_readline1.txt (a simple file that is already present and used by test_readline.js). Note that "../unit" is required to allow for unit_ipc tests that wrap the unit tests.
Attachment #620002 -
Flags: review?(jduell.mcbugs)
Comment 2•13 years ago
|
||
Comment on attachment 620002 [details] [diff] [review] remove references to Xpcomlib Review of attachment 620002 [details] [diff] [review]: ----------------------------------------------------------------- test_readline1.txt is an empty file. I'm guessing we'd get much better test coverage with a non-empty file like test_readline6.txt? Not that reading an empty file isn't a useful test data point...
Assignee | ||
Comment 3•13 years ago
|
||
That's a good point...updated to use test_readline6!
Attachment #620002 -
Attachment is obsolete: true
Attachment #620002 -
Flags: review?(jduell.mcbugs)
Attachment #620012 -
Flags: review?(jduell.mcbugs)
Comment 4•13 years ago
|
||
Comment on attachment 620012 [details] [diff] [review] remove references to Xpcomlib Review of attachment 620012 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. +r with a couple nits fixed. ::: netwerk/test/unit/test_localstreams.js @@ -78,5 @@ > } > > function run_test() { > // Get a file and a directory in order to do some testing > - var file = getDir("XpcomLib"); remove getDir definition from this file too. It's unused after your change. ::: netwerk/test/unit/test_post.js @@ -6,5 @@ > > var httpserver = new nsHttpServer(); > var testpath = "/simple"; > > -var testfile = getFile("XpcomLib"); remove getFile definition from this file too.
Attachment #620012 -
Flags: review?(jduell.mcbugs) → review+
Assignee | ||
Comment 5•13 years ago
|
||
nits addressed (unused functions removed) r=jduell
Attachment #620012 -
Attachment is obsolete: true
Attachment #620114 -
Flags: review+
Assignee | ||
Comment 6•13 years ago
|
||
Passes try: https://tbpl.mozilla.org/?tree=Try&rev=f2cee75d2882
Keywords: checkin-needed
Comment 8•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e56ddb80b935
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•