mozilla/a11y/Role.h:817: error: comma at end of enumerator list

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gaston, Assigned: hub)

Tracking

Trunk
mozilla15
x86
OpenBSD
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
http://hg.mozilla.org/mozilla-central/diff/330f6adec1ec/accessible/src/base/Role.h broke the build on OpenBSD with the error message in summary.. fix in a few.
(Assignee)

Comment 1

5 years ago
I'll fix it
Assignee: nobody → hub
(Reporter)

Comment 2

5 years ago
Created attachment 620036 [details] [diff] [review]
Fix build
Attachment #620036 - Flags: review?(hub)
(Assignee)

Updated

5 years ago
Attachment #620036 - Flags: review?(hub) → review+
(Assignee)

Comment 3

5 years ago
let me know if you need somebody to land it.
(Reporter)

Comment 4

5 years ago
(In reply to Hub Figuiere [:hub] from comment #3)
> let me know if you need somebody to land it.

Well, yes since i can't land it myself :)
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
will land it once m-i is reopen.
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

5 years ago
Actually, I'll let the checkin team do it. Putting back the keyword.
Keywords: checkin-needed
(Assignee)

Comment 7

5 years ago
Created attachment 620107 [details] [diff] [review]
Remove trailing comma at end of enumerator list, breaks build on OpenBSD.
(Assignee)

Comment 8

5 years ago
Comment on attachment 620107 [details] [diff] [review]
Remove trailing comma at end of enumerator list, breaks build on OpenBSD.

Updated with proper commit message checkin. Thanks !
Attachment #620107 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #620036 - Attachment is obsolete: true
(Reporter)

Comment 9

5 years ago
It seems there's another breakage related to #716644..

../../dist/bin/libxul.so.1.0: undefined reference to `nsAccessibleWrap::AtkRoleFor(mozilla::a11y::roles::Role)'

But the code is there in nsAccessibleWrap.cpp and is not #ifdef'ed out...
(Reporter)

Updated

5 years ago
Depends on: 716644
(Assignee)

Comment 10

5 years ago
For that last one, make sure you have
https://hg.mozilla.org/mozilla-central/rev/992588c2eab6
(Reporter)

Comment 11

5 years ago
Ah that might be https://hg.mozilla.org/mozilla-central/rev/992588c2eab6 from https://bugzilla.mozilla.org/show_bug.cgi?id=716644#c65 which i didnt have yet in my checkout.
(Reporter)

Comment 12

5 years ago
Confirmed, that was it.

Comment 13

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e18b59be7262
Keywords: checkin-needed
Target Milestone: --- → mozilla15
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/e18b59be7262
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.