750853 - mozilla/a11y/Role.h:817: error: comma at end of enumerator list

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Landry Breuil (:gaston)]

http://hg.mozilla.org/mozilla-central/diff/330f6adec1ec/accessible/src/base/Role.h broke the build on OpenBSD with the error message in summary.. fix in a few.

Comment 1

[Hubert Figuiere [:hub]]

I'll fix it

Comment 2

[Landry Breuil (:gaston)]

Attachment: Fix build

Comment 3

[Hubert Figuiere [:hub]]

let me know if you need somebody to land it.

Comment 4

[Landry Breuil (:gaston)]

(In reply to Hub Figuiere [:hub] from comment #3)
> let me know if you need somebody to land it.

Well, yes since i can't land it myself :)

Comment 5

[Hubert Figuiere [:hub]]

will land it once m-i is reopen.

Comment 6

[Hubert Figuiere [:hub]]

Actually, I'll let the checkin team do it. Putting back the keyword.

Comment 7

[Hubert Figuiere [:hub]]

Attachment: Remove trailing comma at end of enumerator list, breaks build on OpenBSD.

Comment 8

[Hubert Figuiere [:hub]]

Comment on attachment 620107 [details] [diff] [review]
Remove trailing comma at end of enumerator list, breaks build on OpenBSD.

Updated with proper commit message checkin. Thanks !

Comment 9

[Landry Breuil (:gaston)]

It seems there's another breakage related to #716644..

../../dist/bin/libxul.so.1.0: undefined reference to `nsAccessibleWrap::AtkRoleFor(mozilla::a11y::roles::Role)'

But the code is there in nsAccessibleWrap.cpp and is not #ifdef'ed out...

Comment 10

[Hubert Figuiere [:hub]]

For that last one, make sure you have
https://hg.mozilla.org/mozilla-central/rev/992588c2eab6

Comment 11

[Landry Breuil (:gaston)]

Ah that might be https://hg.mozilla.org/mozilla-central/rev/992588c2eab6 from https://bugzilla.mozilla.org/show_bug.cgi?id=716644#c65 which i didnt have yet in my checkout.

Comment 12

[Landry Breuil (:gaston)]

Confirmed, that was it.

Comment 13

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e18b59be7262

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e18b59be7262