Closed Bug 750959 Opened 8 years ago Closed 8 years ago

Re-enable incremental GC on Android

Categories

(Core :: JavaScript Engine, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15
blocking-kilimanjaro +

People

(Reporter: dmandelin, Assigned: billm)

References

Details

(Keywords: mobile, perf, Whiteboard: [k9o:p1:fx15])

Attachments

(1 file)

IGC is pref'd off on Android because there was a persistent tinderbox failure. I'm marking a dep on bug 686143, but we're not sure that that was the exact problem, or that it's still a problem now. The main thing is just to get IGC going on Android.
Keywords: mobile, perf
I just pushed to try to see if this is still a problem:
https://tbpl.mozilla.org/?tree=Try&rev=fd3d67d329f8
OK, this is cleared for landing (from Brad and Erin via email/in person).

Bill's not ready to re-enable it quite yet on desktop, because he wants to check out a few last issues--should take a week or so. This can go in as soon as it does on desktop, or it can even be part of the same patch. Let me know if this isn't right.
Assignee: general → wmccloskey
Depends on: 735099
No longer depends on: 686143
Attached patch patchSplinter Review
Attachment #622525 - Flags: review?(terrence)
Comment on attachment 622525 [details] [diff] [review]
patch

Review of attachment 622525 [details] [diff] [review]:
-----------------------------------------------------------------

Gross.
Attachment #622525 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/46b2b040973d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.