Last Comment Bug 750960 - OMTC: Qt AppShell should use CurrentThread object for event dispatching
: OMTC: Qt AppShell should use CurrentThread object for event dispatching
Status: RESOLVED FIXED
:
Product: Core Graveyard
Classification: Graveyard
Component: Widget: Qt (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla15
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks: 746800
  Show dependency treegraph
 
Reported: 2012-05-01 16:43 PDT by Oleg Romashin (:romaxa)
Modified: 2016-07-11 21:54 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Use QThread::currentThread for events dispatcher (1.24 KB, patch)
2012-05-01 16:55 PDT, Oleg Romashin (:romaxa)
doug.turner: review+
Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2012-05-01 16:43:10 PDT
Currently nsAppShell dispatcher using qApp->thread() as thread for events dispatching, which is wrong for embedding OMTC setup where we might have qApp in embedding UI thread. and gecko working in different QEventLoop.
Comment 1 Oleg Romashin (:romaxa) 2012-05-01 16:55:42 PDT
Created attachment 620139 [details] [diff] [review]
Use QThread::currentThread for events dispatcher
Comment 2 Doug Turner (:dougt) 2012-05-02 14:40:02 PDT
Comment on attachment 620139 [details] [diff] [review]
Use QThread::currentThread for events dispatcher

Review of attachment 620139 [details] [diff] [review]:
-----------------------------------------------------------------

how did this work before?  we were processing events on the wrong thread?
Comment 3 Oleg Romashin (:romaxa) 2012-05-02 14:48:21 PDT
default builds are single thread, so AppShell and qApplication working in same thread... also qt main loop with glib backend handle these isssues.
this is basically causing problem only with OMTC embedding where qApplication main and appshell work in different threads
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-05-03 04:00:56 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/6df779e244c3
Comment 5 Ed Morley [:emorley] 2012-05-04 03:59:37 PDT
https://hg.mozilla.org/mozilla-central/rev/6df779e244c3

Note You need to log in before you can comment on or make changes to this bug.