OMTC: Qt AppShell should use CurrentThread object for event dispatching

RESOLVED FIXED in mozilla15

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
5 years ago
10 months ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla15
x86
Linux
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Currently nsAppShell dispatcher using qApp->thread() as thread for events dispatching, which is wrong for embedding OMTC setup where we might have qApp in embedding UI thread. and gecko working in different QEventLoop.
(Assignee)

Comment 1

5 years ago
Created attachment 620139 [details] [diff] [review]
Use QThread::currentThread for events dispatcher
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #620139 - Flags: review?(doug.turner)
(Assignee)

Updated

5 years ago
Blocks: 746800

Comment 2

5 years ago
Comment on attachment 620139 [details] [diff] [review]
Use QThread::currentThread for events dispatcher

Review of attachment 620139 [details] [diff] [review]:
-----------------------------------------------------------------

how did this work before?  we were processing events on the wrong thread?
Attachment #620139 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 3

5 years ago
default builds are single thread, so AppShell and qApplication working in same thread... also qt main loop with glib backend handle these isssues.
this is basically causing problem only with OMTC embedding where qApplication main and appshell work in different threads
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6df779e244c3
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6df779e244c3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.