750961 - Avoid GDK_POINTER_MOTION_HINT_MASK / gdk_event_request_motions

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Karl Tomlinson (:karlt)]

Since GDK client side windows (GDK 2.18), GDK_POINTER_MOTION_HINT_MASK is not
implemented with X11 PointerMotionHintMask, but gdk_event_request_motions
still does a gdk_device_get_state which queries the server for state, which is
a round trip.

This code was added in bug 459780, but is not used on Mozilla builds because
of old GTK versions there.

It would make sense to disable this for desktop builds against newer GTK also, so that distributions get the same mouse behaviour.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: disable motion hints to avoid gdk_event_request_motions unless on Maemo

This leaves the motion hints on Maemo, as X11 MotionNotify compression doesn't yet properly handle extension events (bug 459780).
Does anyone still build the GTK port for Maemo?

Comment 2

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ead1d72d499

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4ead1d72d499