Avoid GDK_POINTER_MOTION_HINT_MASK / gdk_event_request_motions

RESOLVED FIXED in mozilla15

Status

()

Core
Widget: Gtk
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Other Branch
mozilla15
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Since GDK client side windows (GDK 2.18), GDK_POINTER_MOTION_HINT_MASK is not
implemented with X11 PointerMotionHintMask, but gdk_event_request_motions
still does a gdk_device_get_state which queries the server for state, which is
a round trip.

This code was added in bug 459780, but is not used on Mozilla builds because
of old GTK versions there.

It would make sense to disable this for desktop builds against newer GTK also, so that distributions get the same mouse behaviour.
(Assignee)

Comment 1

5 years ago
Created attachment 620148 [details] [diff] [review]
disable motion hints to avoid gdk_event_request_motions unless on Maemo

This leaves the motion hints on Maemo, as X11 MotionNotify compression doesn't yet properly handle extension events (bug 459780).
Does anyone still build the GTK port for Maemo?
Assignee: nobody → karlt
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #620148 - Flags: review?(roc)
Attachment #620148 - Flags: review?(roc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ead1d72d499
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/4ead1d72d499
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.